Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298743002: Prevent modifying path separator on Windows by shlex.split() (Closed)

Created:
6 years, 7 months ago by prasadv
Modified:
6 years, 7 months ago
Reviewers:
shatch, qyearsley
CC:
chromium-reviews
Visibility:
Public.

Description

Prevent modifying path separator on Windows by shlex.split() BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/bisect-perf-regression.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
prasadv
6 years, 7 months ago (2014-05-20 18:20:31 UTC) #1
qyearsley
LGTM
6 years, 7 months ago (2014-05-20 18:28:16 UTC) #2
shatch
lgtm
6 years, 7 months ago (2014-05-20 18:37:02 UTC) #3
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 7 months ago (2014-05-20 18:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/298743002/1
6 years, 7 months ago (2014-05-20 18:38:13 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 18:40:11 UTC) #6
Message was sent while issue was closed. 
Change committed as 271718

Powered by Google App Engine
This is Rietveld 408576698