Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: tools/bisect-perf-regression.py

Issue 298743002: Prevent modifying path separator on Windows by shlex.split() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index e5a615e68d332232fc042eafc00c1192568d224b..c0eccf354e8cc0b32822acc4f887f15ad00a3f62 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2094,7 +2094,10 @@ class BisectPerformanceMetrics(object):
}
return (fake_results, success_code)
- args = shlex.split(command_to_run)
+ # For Windows platform set posix=False, to parse windows paths correctly.
+ # On Windows, path separators '\' or '\\' are replace by '' when posix=True,
+ # refer to http://bugs.python.org/issue1724822. By default posix=True.
+ args = shlex.split(command_to_run, posix=not IsWindows())
if not self._GenerateProfileIfNecessary(args):
err_text = 'Failed to generate profile for performance test.'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698