Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2987383002: tokenserver: Protos for service account rules. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

tokenserver: Protos for service account rules. Also slightly change RPC messages (unused yet) for consistency. R=smut@google.com BUG=731843 Review-Url: https://codereview.chromium.org/2987383002 Committed: https://github.com/luci/luci-go/commit/5e63e25d0fb4fdcc6adc8afceb24a9244f06c724

Patch Set 1 #

Total comments: 10

Patch Set 2 : tokenserver: Protos for service account rules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2401 lines, -2182 lines) Patch
M tokenserver/api/admin/v1/config.proto View 1 3 chunks +64 lines, -6 lines 0 comments Download
M tokenserver/api/admin/v1/config.pb.go View 1 5 chunks +138 lines, -45 lines 0 comments Download
M tokenserver/api/admin/v1/pb.discovery.go View 1 1 chunk +1190 lines, -1125 lines 0 comments Download
M tokenserver/api/minter/v1/pb.discovery.go View 1 chunk +893 lines, -893 lines 0 comments Download
M tokenserver/api/minter/v1/token_minter.proto View 2 chunks +2 lines, -2 lines 0 comments Download
M tokenserver/api/minter/v1/token_minter.pb.go View 5 chunks +77 lines, -77 lines 0 comments Download
M tokenserver/api/oauth_token_grant.proto View 1 chunk +5 lines, -3 lines 0 comments Download
M tokenserver/api/oauth_token_grant.pb.go View 3 chunks +32 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Vadim Sh.
This is proto-only changes in unused protos.
3 years, 4 months ago (2017-08-02 22:35:01 UTC) #1
smut
Lgtm. I normally wouldn't be this pedantic, but the cl was mostly comments so I ...
3 years, 4 months ago (2017-08-02 23:04:17 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2987383002/diff/1/tokenserver/api/admin/v1/config.proto File tokenserver/api/admin/v1/config.proto (right): https://codereview.chromium.org/2987383002/diff/1/tokenserver/api/admin/v1/config.proto#newcode94 tokenserver/api/admin/v1/config.proto:94: // Email of developers that owns this rule, to ...
3 years, 4 months ago (2017-08-03 00:23:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987383002/20001
3 years, 4 months ago (2017-08-03 00:23:54 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 00:28:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/5e63e25d0fb4fdcc6adc8afceb24a9244f06c724

Powered by Google App Engine
This is Rietveld 408576698