Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2987: Don't try an indexOf() when the search string is bigger than the string. (Closed)

Created:
12 years, 3 months ago by Dean McNamee
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't try an indexOf() when the search string is bigger than the string. The current code will spend a bunch of time trying to match, even though we should know a match is impossible.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/string.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dean McNamee
12 years, 3 months ago (2008-09-19 11:27:28 UTC) #1
Mads Ager (chromium)
LGTM
12 years, 3 months ago (2008-09-19 11:28:49 UTC) #2
Mads Ager (chromium)
12 years, 3 months ago (2008-09-19 11:29:02 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698