src/string.js - Issue 2987: Don't try an indexOf() when the search string is bigger than the string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 2987: Don't try an indexOf() when the search string is bigger than the string. (Closed)

Patch Set: Created 12 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index da9ba6acb89893d0e7f070359f10912db5db5f47..1a13d16428a2dbb961578b978566ff44edf49738 100644

--- a/src/string.js

+++ b/src/string.js

@@ -340,6 +340,7 @@ function ApplyReplacementFunction(replace, captures, subject) {

}

if (index < 0) index = 0;

if (index > str.length) index = str.length;

+ if (searchStr.length + index > str.length) return -1;

return %StringIndexOf(str, searchStr, index);

}, DONT_ENUM);

« no previous file with comments | « no previous file | no next file » | no next file with comments »