Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2986953002: gitiles: go back to QueryEscape because url.PathEscape is not in Go1.6. (Closed)

Created:
3 years, 4 months ago by tandrii(chromium)
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

gitiles: go back to QueryEscape because url.PathEscape is not in Go1.6. R=hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2986953002 Committed: https://github.com/luci/luci-go/commit/b8f38ac193dee1f11001aabfa3a9b484706f9ce0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M common/api/gitiles/gitiles.go View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tandrii(chromium)
3 years, 4 months ago (2017-07-27 14:07:00 UTC) #1
Ryan Tseng
lgtm
3 years, 4 months ago (2017-07-27 14:08:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2986953002/1
3 years, 4 months ago (2017-07-27 14:09:17 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 14:14:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/b8f38ac193dee1f11001aabfa3a9b484706f9ce0

Powered by Google App Engine
This is Rietveld 408576698