Add assist to convert part-of directives

Add assist to convert part-of directives

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/950b4108f76236be4ed0d74e81fc2d62d3323262

[Brian Wilkerson, 2017-07-26 14:43:05]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-07-26 15:06:56]

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:666: if
(element is LibraryElement) {
There is unitLibraryElement already available for assists.

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:667: Uri
uri = driver.sourceFactory.restoreUri(element.source);
This makes me wonder why we created restoreUri() at all?
Why not use source.uri?

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:671:
libraryUri = relative(uri.path, from: dirname(file));
from: unitLibraryFolder

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/2986903002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/assist_test.dart:1045:
test_convertPartOfToUri_file() async {
Can we add a test for package URIs?

Can we add a test for a non-trivial relative file URI?

[Brian Wilkerson, 2017-07-26 15:58:33]

ptal

After seeing your request for a package URI test I decided that I don't want to
produce anything other than relative URIs, so I changed it to ignore the kind of
URI and use the file path instead.

[scheglov, 2017-07-26 16:08:03]

LGTM

[Brian Wilkerson, 2017-07-26 16:08:41]

Description was changed from

==========
Add assist to convert part-of directives
==========

to

==========
Add assist to convert part-of directives

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/950b4108f76236be4ed0d74e81fc2d62d3323262
==========

[Brian Wilkerson, 2017-07-26 16:08:42]

Committed patchset #2 (id:20001) manually as
950b4108f76236be4ed0d74e81fc2d62d3323262 (presubmit successful).