Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 2986903002: Add assist to convert part-of directives (Closed)
Patch Set: reworked Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
index 8328e32ae3de52e1df2f8cd09ec7ed1635f5d44e..872663bacd44cd54c212f50d0d5720f60568bcb7 100644
--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
@@ -128,6 +128,7 @@ class AssistProcessor {
await _addProposal_convertToBlockFunctionBody();
await _addProposal_convertToExpressionFunctionBody();
await _addProposal_convertFlutterChild();
+ await _addProposal_convertPartOfToUri();
await _addProposal_convertToForIndexLoop();
await _addProposal_convertToIsNot_onIs();
await _addProposal_convertToIsNot_onNot();
@@ -655,6 +656,23 @@ class AssistProcessor {
_addAssistFromBuilder(changeBuilder, DartAssistKind.CONVERT_INTO_GETTER);
}
+ Future<Null> _addProposal_convertPartOfToUri() async {
+ PartOfDirective directive =
+ node.getAncestor((node) => node is PartOfDirective);
+ if (directive == null || directive.libraryName == null) {
+ return;
+ }
+ String libraryPath = unitLibraryElement.source.fullName;
+ String partPath = unit.element.source.fullName;
+ String relativePath = relative(libraryPath, from: dirname(partPath));
+ SourceRange replacementRange = range.node(directive.libraryName);
+ DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
+ await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {
+ builder.addSimpleReplacement(replacementRange, "'$relativePath'");
+ });
+ _addAssistFromBuilder(changeBuilder, DartAssistKind.CONVERT_PART_OF_TO_URI);
+ }
+
Future<Null> _addProposal_convertToBlockFunctionBody() async {
FunctionBody body = getEnclosingFunctionBody();
// prepare expression body

Powered by Google App Engine
This is Rietveld 408576698