Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2986873002: Fix status for int_modulo_arith_test/none (Closed)

Created:
3 years, 4 months ago by kevmoo
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, sra1
CC:
reviews_dartlang.org, bkonyi
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix status for int_modulo_arith_test/none Follow up from https://codereview.chromium.org/2990623002 @ c347b0ed16 Committed: https://github.com/dart-lang/sdk/commit/4afc45c2d97bcd287aaf6d0699d2f32e3c081fa3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tests/corelib_2/corelib_2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kevmoo
TBR
3 years, 4 months ago (2017-07-26 05:43:44 UTC) #2
kevmoo
Committed patchset #1 (id:1) manually as 4afc45c2d97bcd287aaf6d0699d2f32e3c081fa3 (presubmit successful).
3 years, 4 months ago (2017-07-26 05:44:03 UTC) #4
sra1
Does anyone know why int_modulo_arith_test/none started passing on dart2js? Ben - did you make any ...
3 years, 4 months ago (2017-07-26 16:51:57 UTC) #6
Bob Nystrom
3 years, 4 months ago (2017-07-26 17:16:51 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698