navigator.vibrate() crash avoidance when in a detached state.

navigator.vibrate() crash avoidance when in a detached state.

If the frame isn't present, gracefully return.

R=mvanouwerkerk@chromium.org,haraken@chromium.org
BUG=375004
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174380

[sof, 2014-05-20 10:53:48]

Please take a look.

Something to check&look out for when doing Navigator supplementables.

[haraken, 2014-05-20 10:56:48]

LGTM. Thanks for the test.

https://codereview.chromium.org/298683002/diff/1/Source/modules/vibration/Nav...
File Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/298683002/diff/1/Source/modules/vibration/Nav...
Source/modules/vibration/NavigatorVibration.cpp:148: Page* page =
navigator.frame() ? navigator.frame()->page() : 0;

Or you can write:

if (!navigator.frame())
  return false;

[Michael van Ouwerkerk, 2014-05-20 11:00:45]

lgtm, thanks Sigbjørn!

[sof, 2014-05-20 12:42:45]

Thanks both for the quick reviews.

https://codereview.chromium.org/298683002/diff/1/Source/modules/vibration/Nav...
File Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/298683002/diff/1/Source/modules/vibration/Nav...
Source/modules/vibration/NavigatorVibration.cpp:148: Page* page =
navigator.frame() ? navigator.frame()->page() : 0;
On 2014/05/20 10:56:48, haraken wrote:
> 
> Or you can write:
> 
> if (!navigator.frame())
>   return false;

Done.

[sof, 2014-05-20 12:42:51]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-05-20 12:43:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/298683002/20001

[commit-bot: I haz the power, 2014-05-20 13:56:44]

Change committed as 174380