LayoutTests/vibration/vibration-detached-no-crash.html - Issue 298683002: navigator.vibrate() crash avoidance when in a detached state.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/vibration/vibration-detached-no-crash.html

Issue 298683002: navigator.vibrate() crash avoidance when in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rephrase null check Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/vibration/resources/vibration-detached-no-crash-new-window.html ('k') | LayoutTests/vibration/vibration-detached-no-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <body>

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 <script src="vibration-utils.js"></script>

	6 </head>

	7 <script>

	8 description("Accessing navigator.vibrate on a closed window.");

	9

	10 window.jsTestIsAsync = true;

	11

	12 var w;

	13 function processMessage(event) {

	14 if (event.data == "opened") {

	15 w.close();

	16 } else if (event.data == "closed") {

	17 shouldBeFalse("w.navigator.vibrate([])");

	18 finishJSTest();

	19 }

	20 }

	21

	22 if (window.testRunner) {

	23 testRunner.dumpAsText();

	24 testRunner.setCanOpenWindows();

	25 }

	26 w = window.open('resources/vibration-detached-no-crash-new-window.html');

	27 window.addEventListener("message", processMessage, false);

	28 </script>

	29 </body>

OLD	NEW