Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2986773002: isolate: pull uploading of deps out of exparchive main. (Closed)

Created:
3 years, 5 months ago by mcgreevy
Modified:
3 years, 5 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: pull uploading of deps out of exparchive main. BUG=692940 Review-Url: https://codereview.chromium.org/2986773002 Committed: https://github.com/luci/luci-go/commit/9bc2ed3aa0aabf8591e8f0c6f889cdb4c02d90f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -46 lines) Patch
M client/cmd/isolate/exp_archive.go View 4 chunks +54 lines, -46 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
mcgreevy
3 years, 5 months ago (2017-07-24 04:38:59 UTC) #3
mcgreevy
On 2017/07/24 04:38:59, mcgreevy wrote: @tansell: can you review. I pulled this out of a ...
3 years, 5 months ago (2017-07-24 04:42:22 UTC) #4
mithro
This is just a code move right? If so, LGTM.
3 years, 5 months ago (2017-07-24 06:21:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2986773002/1
3 years, 5 months ago (2017-07-24 06:26:09 UTC) #7
mcgreevy
On 2017/07/24 06:21:31, mithro wrote: > This is just a code move right? > > ...
3 years, 5 months ago (2017-07-24 06:26:32 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 06:34:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/9bc2ed3aa0aabf8591e8f0c6f889cdb4c02d90f7

Powered by Google App Engine
This is Rietveld 408576698