Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2986733002: Reland of Make ProfileIOData use URLRequestContextBuilder (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make ProfileIOData use URLRequestContextBuilder (patchset #1 id:1 of https://codereview.chromium.org/2986623002/ ) Reason for revert: We're now after branch, re-landing this (Since I'll need it for a number of CLs). I'll fix devtools in a followup CL, and merge the revert if needed. Original issue's description: > Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ ) > > Reason for revert: > Wasn't thinking when I landed this just before branch. > > Original issue's description: > > Make ProfileIOData use URLRequestContextBuilder > > > > BUG=734199 > > > > Review-Url: https://codereview.chromium.org/2978443002 > > Cr-Commit-Position: refs/heads/master@{#487590} > > Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f > > TBR=rdsmith@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=734199 > > Review-Url: https://codereview.chromium.org/2986623002 > Cr-Commit-Position: refs/heads/master@{#488562} > Committed: https://chromium.googlesource.com/chromium/src/+/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de TBR=rdsmith@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=734199 Review-Url: https://codereview.chromium.org/2986733002 Cr-Commit-Position: refs/heads/master@{#488887} Committed: https://chromium.googlesource.com/chromium/src/+/1c261ff43979396e53729da97763a8d261c7616c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+551 lines, -354 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +33 lines, -23 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.h View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 2 chunks +0 lines, -68 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 3 chunks +31 lines, -36 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 3 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 9 chunks +78 lines, -51 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 8 chunks +34 lines, -23 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 15 chunks +133 lines, -87 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 12 chunks +80 lines, -17 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 14 chunks +128 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mmenke
Created Reland of Make ProfileIOData use URLRequestContextBuilder
3 years, 5 months ago (2017-07-23 15:34:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2986733002/1
3 years, 5 months ago (2017-07-23 15:34:39 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-23 17:06:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c261ff43979396e53729da97763...

Powered by Google App Engine
This is Rietveld 408576698