Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2986653002: Work around bot failures, allowing for the static test to fail (Closed)

Created:
3 years, 5 months ago by jcollins
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, eernst, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around bot failures, allowing for the static test to fail statically in checked mode. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/ffdfe8947575d3e2405f7bbfb8e1b2b42d19ffb1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tests/corelib_2/corelib_2.status View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 6 (2 generated)
jcollins
Fix the bot problem with the new static test.
3 years, 5 months ago (2017-07-21 16:32:10 UTC) #2
Bob Nystrom
https://codereview.chromium.org/2986653002/diff/1/tests/corelib_2/corelib_2.status File tests/corelib_2/corelib_2.status (right): https://codereview.chromium.org/2986653002/diff/1/tests/corelib_2/corelib_2.status#newcode9 tests/corelib_2/corelib_2.status:9: [ !$strong && $compiler != dartdevc && $checked ] ...
3 years, 5 months ago (2017-07-21 16:33:20 UTC) #3
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-21 16:33:26 UTC) #4
jcollins
3 years, 5 months ago (2017-07-21 16:34:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ffdfe8947575d3e2405f7bbfb8e1b2b42d19ffb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698