Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: tests/corelib_2/corelib_2.status

Issue 2986653002: Work around bot failures, allowing for the static test to fail (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib_2/corelib_2.status
diff --git a/tests/corelib_2/corelib_2.status b/tests/corelib_2/corelib_2.status
index 8588dc9ca62ac03cb5ad47f30e73f331c660d985..1adfdac6a5245b7f284be7a6b19578e83cc6fb2c 100644
--- a/tests/corelib_2/corelib_2.status
+++ b/tests/corelib_2/corelib_2.status
@@ -2,11 +2,15 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
-#[ $strong && $compiler != dart2analyzer ]
# All static_tests have expected compile-time errors.
[ $strong && $compiler != dart2analyzer && $compiler != dartdevc ]
core_runtime_types_static_test: MissingCompileTimeError
+[ !$strong && $compiler != dartdevc && $checked ]
Bob Nystrom 2017/07/21 16:33:20 I think you can omit the "$compiler != dartdevc".
+core_runtime_types_static_test: MissingCompileTimeError
+
+[ !$strong && !$checked ]
+core_runtime_types_static_test: MissingCompileTimeError
[ $compiler == dart2js && $fast_startup ]
apply3_test: Fail # mirrors not supported
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698