Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2986533002:
[datastore] Fix querying with []byte. (Closed)
Description[datastore] Fix querying with []byte.
impl/prod previously converted []byte to datastore.ByteString for indexed
properties and the equality filters are internally represented with indexed
properties. However, the datastore SDK rejects ByteString as an equality
filter (even though that's what you're supposed to use if you want an
indexed []byte in a model).
R=dnj@chromium.org, hinoka@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2986533002
Committed: https://github.com/luci/gae/commit/a1138385b0ad564e9baf32dc6f7f5eb1ae4eb886
Patch Set 1 #Patch Set 2 : more targeted fix #Patch Set 3 : add crappy test #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
looks good, but please add a unit test
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-GAE Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3776c467c0294610)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/20 03:04:55, dnj wrote: > looks good, but please add a unit test This is actually just scoped to prod, reworked (all the tests that do exist blew up)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [datastore] Fix querying with []byte. Apparently no one has done this before :). This triggers a bug in impl/prod which converts []byte to datastore.ByteString for indexed properties. By making the equality filters non-indexed, we avoid this (the type of the value remains []byte). The indexed-ness of the eq filter properties doesn't actually affect anything. R=dnj@chromium.org, hinoka@chromium.org BUG= ========== to ========== [datastore] Fix querying with []byte. impl/prod previously converted []byte to datastore.ByteString for indexed properties and the equality filters are internally represented with indexed properties. However, the datastore SDK rejects ByteString as an equality filter (even though that's what you're supposed to use if you want an indexed ByteString in a model). R=dnj@chromium.org, hinoka@chromium.org BUG= ==========
Description was changed from ========== [datastore] Fix querying with []byte. impl/prod previously converted []byte to datastore.ByteString for indexed properties and the equality filters are internally represented with indexed properties. However, the datastore SDK rejects ByteString as an equality filter (even though that's what you're supposed to use if you want an indexed ByteString in a model). R=dnj@chromium.org, hinoka@chromium.org BUG= ========== to ========== [datastore] Fix querying with []byte. impl/prod previously converted []byte to datastore.ByteString for indexed properties and the equality filters are internally represented with indexed properties. However, the datastore SDK rejects ByteString as an equality filter (even though that's what you're supposed to use if you want an indexed []byte in a model). R=dnj@chromium.org, hinoka@chromium.org BUG= ==========
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1500522142332490,
"parent_rev": "52a3b010d9f5696bfb2c9be999402bb8b27af38e", "commit_rev":
"a1138385b0ad564e9baf32dc6f7f5eb1ae4eb886"}
Message was sent while issue was closed.
Description was changed from ========== [datastore] Fix querying with []byte. impl/prod previously converted []byte to datastore.ByteString for indexed properties and the equality filters are internally represented with indexed properties. However, the datastore SDK rejects ByteString as an equality filter (even though that's what you're supposed to use if you want an indexed []byte in a model). R=dnj@chromium.org, hinoka@chromium.org BUG= ========== to ========== [datastore] Fix querying with []byte. impl/prod previously converted []byte to datastore.ByteString for indexed properties and the equality filters are internally represented with indexed properties. However, the datastore SDK rejects ByteString as an equality filter (even though that's what you're supposed to use if you want an indexed []byte in a model). R=dnj@chromium.org, hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2986533002 Committed: https://github.com/luci/gae/commit/a1138385b0ad564e9baf32dc6f7f5eb1ae4eb886 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/gae/commit/a1138385b0ad564e9baf32dc6f7f5eb1ae4eb886 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
