Change Shell / ShellClient to ServiceProvider

Change Shell / ShellClient to ServiceProvider

BUG=
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272983

[DaveMoore, 2014-05-23 20:05:44]

Cleanup

[DaveMoore, 2014-05-23 20:06:55]

This change only does the rename and merging of Shell / ShellClient into
ServiceProvider. Subsequent changes will add new capabilities.

[DaveMoore, 2014-05-23 20:20:02]

Cleanup

[DaveMoore, 2014-05-23 22:13:00]

Make content work

[DaveMoore, 2014-05-23 22:24:57]

Support content Mojo stuff

[darin (slow to review), 2014-05-24 03:15:01]

LGTM

https://codereview.chromium.org/298653010/diff/80001/mojo/public/interfaces/s...
File mojo/public/interfaces/service_provider/service_provider.mojom (right):

https://codereview.chromium.org/298653010/diff/80001/mojo/public/interfaces/s...
mojo/public/interfaces/service_provider/service_provider.mojom:7:
[Client=ServiceProvider]
It'd be good to add some documentation here to explain what it means for SP to
be a client of itself.

[DaveMoore, 2014-05-26 01:11:20]

The CQ bit was checked by davemoore@chromium.org

[commit-bot: I haz the power, 2014-05-26 01:11:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davemoore@chromium.org/298653010/80001

[commit-bot: I haz the power, 2014-05-26 01:16:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-26 01:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 01:21:15]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[DaveMoore, 2014-05-27 15:51:06]

Committed patchset #5 manually as r272983 (presubmit successful).

[tim (not reviewing), 2014-06-17 02:34:59]

On 2014/05/24 03:15:01, darin wrote:
> LGTM
> 
>
https://codereview.chromium.org/298653010/diff/80001/mojo/public/interfaces/s...
> File mojo/public/interfaces/service_provider/service_provider.mojom (right):
> 
>
https://codereview.chromium.org/298653010/diff/80001/mojo/public/interfaces/s...
> mojo/public/interfaces/service_provider/service_provider.mojom:7:
> [Client=ServiceProvider]
> It'd be good to add some documentation here to explain what it means for SP to
> be a client of itself.

^^^ I'm having a bit of trouble following this actually.  When the
ServiceManager loads a service, it creates and binds a ServiceFactory to a pipe
and passes the other end to the ServiceProvider client's ConnectToService...
what's happening here?