mojo/public/interfaces/service_provider/service_provider.mojom - Issue 298653010: Change Shell / ShellClient to ServiceProvider

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/service_provider/service_provider.mojom

Issue 298653010: Change Shell / ShellClient to ServiceProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Support content Mojo stuff Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module mojo {	5 module mojo {

6	6

7 [Client=ShellClient]	7 [Client=ServiceProvider]
	darin (slow to review) 2014/05/24 03:15:02 It'd be good to add some documentation here to exp It'd be good to add some documentation here to explain what it means for SP to be a client of itself.
8 interface Shell {	8 interface ServiceProvider {

9 // Loads url. mojo:{service} will result in the user of the value of the	9 // Loads url. mojo:{service} will result in the user of the value of the

10 // --origin flag to the shell being used.	10 // --origin flag to the shell being used.

11 Connect(string url, handle<message_pipe> client_handle);	11 ConnectToService(string url, handle<message_pipe> client_handle);

12 };

13

14 interface ShellClient {

15 AcceptConnection(string url, handle<message_pipe> client_handle);

16 };	12 };

17	13

18 }	14 }

OLD	NEW