Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 298653008: Linux ARM Cross-Compile recipe (Closed)

Created:
6 years, 7 months ago by nodir
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org, Mark Seaborn
Visibility:
Public.

Description

Linux ARM Cross-Compile recipe Converted Linux ARM Cross-Compile builder on chromium.fyi master to a recipe. R=phajdan.jr@chromium.org BUG=359338 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272598

Patch Set 1 #

Total comments: 3

Patch Set 2 : changed target to all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -13 lines) Patch
M scripts/slave/recipes/chromium.py View 1 3 chunks +40 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_ChromeOS.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS__Clang_dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_ARM_Cross_Compile.json View 1 4 chunks +13 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit_x64.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_MacGit.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGit.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGitXP.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Clang__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Sync.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Sync.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__4_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__4_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Interactive_Tests__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_64_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync_x64.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__4_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__5_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__6_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__1_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__3_.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nodir
https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromium.py File scripts/slave/recipes/chromium.py (right): https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromium.py#newcode474 scripts/slave/recipes/chromium.py:474: 'chromium_swarm_tests', Pawel, can you confirm that this will compile ...
6 years, 7 months ago (2014-05-23 01:24:21 UTC) #1
Paweł Hajdan Jr.
LGTM with comments https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromium.py File scripts/slave/recipes/chromium.py (right): https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromium.py#newcode474 scripts/slave/recipes/chromium.py:474: 'chromium_swarm_tests', On 2014/05/23 01:24:22, nodir wrote: ...
6 years, 7 months ago (2014-05-23 08:49:45 UTC) #2
nodir
On 2014/05/23 08:49:45, Paweł Hajdan Jr. wrote: > LGTM with comments > > https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromium.py > ...
6 years, 7 months ago (2014-05-23 21:45:10 UTC) #3
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 7 months ago (2014-05-23 21:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/298653008/20001
6 years, 7 months ago (2014-05-23 21:47:07 UTC) #5
commit-bot: I haz the power
Change committed as 272598
6 years, 7 months ago (2014-05-23 21:48:40 UTC) #6
nodir
6 years, 7 months ago (2014-05-27 19:17:15 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium.py (right):

https://codereview.chromium.org/298653008/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium.py:474: 'chromium_swarm_tests',
On 2014/05/23 08:49:46, Paweł Hajdan Jr. wrote:
> On 2014/05/23 01:24:22, nodir wrote:
> > Pawel, can you confirm that this will compile browser_tests?
> 
> If you want to be sure please add them explicitly - make the intent clear and
> avoid assumptions that may get invalidated.
> 
> Please see src/build/all.gyp : chromium_swarm_tests will compile
browser_tests,
> but needs test_isolation_mode != noop. It seems this should be used if you
want
> to use swarm.
> 
> And if you want to compile browser_tests, use "browser_tests" or "all".
> 
> These chromium_* compile targets were created before recipes, so that one
could
> change what they build without restarting the master.

Do we really need to specify targets here? They seem to be read from test spec
file as well, which specifies the exact targets we need.

Powered by Google App Engine
This is Rietveld 408576698