Linux ARM Cross-Compile recipe

scripts/slave/recipes/chromium.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'archive',
   'bot_update',
   'chromium',
   'gclient',
   'json',
@@ skipping 434 matching lines @@
           'testing': {'platform': 'linux'},
       },
       'LinuxGit x64': {
           'recipe_config': 'chromium',
           'testing': {'platform': 'linux'},
       },
     }
   },
   'chromium.fyi': {
     'builders': {
+      'Linux ARM Cross-Compile': {
+        # TODO(phajdan.jr): Re-enable goma, http://crbug.com/349236 .
+        'recipe_config': 'chromium_no_goma',
+        'GYP_DEFINES': {
+          'target_arch': 'arm',
+          'arm_float_abi': 'hard',
+          'test_isolation_mode': 'archive',
+        },
+        'chromium_config': 'chromium',
+        'runhooks_env': {
+          'AR': 'arm-linux-gnueabihf-ar',
+          'AS': 'arm-linux-gnueabihf-as',
+          'CC': 'arm-linux-gnueabihf-gcc',
+          'CC_host': 'gcc',
+          'CXX': 'arm-linux-gnueabihf-g++',
+          'CXX_host': 'g++',
+          'RANLIB': 'arm-linux-gnueabihf-ranlib',
+        },
+        'compile_targets': [
+            'chromium_swarm_tests',

[nodir, 2014/05/23 01:24:22]

Pawel, can you confirm that this will compile browser_tests?

[Paweł Hajdan Jr., 2014/05/23 08:49:46]

If you want to be sure please add them explicitly - make the intent clear and
avoid assumptions that may get invalidated.

Please see src/build/all.gyp : chromium_swarm_tests will compile browser_tests,
but needs test_isolation_mode != noop. It seems this should be used if you want
to use swarm.

And if you want to compile browser_tests, use "browser_tests" or "all".

These chromium_* compile targets were created before recipes, so that one could
change what they build without restarting the master.

[nodir, 2014/05/27 19:17:15]

Do we really need to specify targets here? They seem to be read from test spec
file as well, which specifies the exact targets we need.

+        ],
+        'testing': {
+          'platform': 'linux',
+          'test_spec_file': 'chromium_arm.json',
+        },
+      },
       'Linux Trusty': {
         # TODO(phajdan.jr): Re-enable goma, http://crbug.com/349236 .
         'recipe_config': 'chromium_no_goma',
         'chromium_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 64,
         },
         'bot_type': 'builder_tester',
         'compile_targets': [
           'all',
@@ skipping 1011 matching lines @@
   bot_config = master_dict.get('builders', {}).get(buildername)
   master_config = master_dict.get('settings', {})
   recipe_config_name = bot_config['recipe_config']
   assert recipe_config_name, (
       'Unrecognized builder name %r for master %r.' % (
           buildername, mastername))
   recipe_config = RECIPE_CONFIGS[recipe_config_name]
 
   api.chromium.set_config(recipe_config['chromium_config'],
                           **bot_config.get('chromium_config_kwargs', {}))
+  # Set GYP_DEFINES explicitly because chromium config constructor does
+  # not support that.
+  api.chromium.c.gyp_env.GYP_DEFINES.update(bot_config.get('GYP_DEFINES', {}))
   for c in recipe_config.get('chromium_apply_config', []):
     api.chromium.apply_config(c)
   api.gclient.set_config(recipe_config['gclient_config'])
   for c in recipe_config.get('gclient_apply_config', []):
     api.gclient.apply_config(c)
 
   if api.platform.is_win:
     yield api.chromium.taskkill()
 
   # Bot Update re-uses the gclient configs.
   yield api.bot_update.ensure_checkout(),
   if not api.step_history.last_step().json.output['did_run']:
     yield api.gclient.checkout(),
   # Whatever step is run right before this line needs to emit got_revision.
   update_step = api.step_history.last_step()
   got_revision = update_step.presentation.properties['got_revision']
 
   bot_type = bot_config.get('bot_type', 'builder_tester')
 
   if not bot_config.get('disable_runhooks'):
-    yield api.chromium.runhooks()
+    yield api.chromium.runhooks(env=bot_config.get('runhooks_env', {}))
 
+  test_spec_file = bot_config.get('testing', {}).get('test_spec_file',
+                                                     '%s.json' % mastername)
+  test_spec_path = api.path['checkout'].join('testing', 'buildbot',
+                                             test_spec_file)
+  def test_spec_followup_fn(step_result):
+    step_result.presentation.step_text = 'path: %s' % test_spec_path
   yield api.json.read(
       'read test spec',
-      api.path['checkout'].join('testing', 'buildbot', '%s.json' % mastername),
-      step_test_data=lambda: api.json.test_api.output({})),
+      test_spec_path,
+      step_test_data=lambda: api.json.test_api.output({}),
+      followup_fn=test_spec_followup_fn),
   yield api.chromium.cleanup_temp()
 
   # For non-trybot recipes we should know (seed) all steps in advance,
   # once we read the test spec. Instead of yielding single steps
   # or groups of steps, yield all of them at the end.
   steps = []
 
   if bot_type in ['builder', 'builder_tester']:
     compile_targets = set(bot_config.get('compile_targets', []))
     for test in bot_config.get('tests', []):
@@ skipping 87 matching lines @@
     api.platform('linux', 64) +
     api.override_step_data('read test spec', api.json.output({
       'Linux Tests': {
         'gtest_tests': [
           'base_unittests',
           {'test': 'browser_tests', 'shard_index': 0, 'total_shards': 2},
         ],
       },
     }))
   )