Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2986223002: Add tests for BuildGroup names (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -144 lines) Patch
M tools/gardening/lib/src/buildbot_data.dart View 15 chunks +130 lines, -136 lines 0 comments Download
M tools/gardening/lib/src/buildbot_loading.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/client.dart View 1 2 chunks +7 lines, -3 lines 0 comments Download
M tools/gardening/lib/src/util.dart View 1 chunk +14 lines, -1 line 0 comments Download
A tools/gardening/test/buildbot_data_test.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download
M tools/gardening/test/test_client.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-01 14:43:03 UTC) #2
Dmitry Stefantsov
LGTM with one small comment. https://codereview.chromium.org/2986223002/diff/1/tools/gardening/lib/src/buildbot_loading.dart File tools/gardening/lib/src/buildbot_loading.dart (right): https://codereview.chromium.org/2986223002/diff/1/tools/gardening/lib/src/buildbot_loading.dart#newcode36 tools/gardening/lib/src/buildbot_loading.dart:36: HttpClient client, BuildUri buildUri) ...
3 years, 4 months ago (2017-08-02 09:27:01 UTC) #3
Johnni Winther
https://codereview.chromium.org/2986223002/diff/1/tools/gardening/lib/src/buildbot_loading.dart File tools/gardening/lib/src/buildbot_loading.dart (right): https://codereview.chromium.org/2986223002/diff/1/tools/gardening/lib/src/buildbot_loading.dart#newcode36 tools/gardening/lib/src/buildbot_loading.dart:36: HttpClient client, BuildUri buildUri) async { On 2017/08/02 09:27:00, ...
3 years, 4 months ago (2017-08-02 10:18:30 UTC) #4
Johnni Winther
3 years, 4 months ago (2017-08-02 10:18:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f22caf40282fe63f711988a2db1bd8e4b1752280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698