Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gardening/lib/src/buildbot_data.dart

Issue 2986223002: Add tests for BuildGroup names (Closed)
Patch Set: Updated cf. comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gardening/lib/src/buildbot_loading.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/buildbot_data.dart
diff --git a/tools/gardening/lib/src/buildbot_data.dart b/tools/gardening/lib/src/buildbot_data.dart
index 60d31a7e19d6dcdcdd8f53d220ab76a8196c3637..f017cbd5ae58888dd1cbee9ec34d9762a857e87b 100644
--- a/tools/gardening/lib/src/buildbot_data.dart
+++ b/tools/gardening/lib/src/buildbot_data.dart
@@ -177,7 +177,7 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
const BuildSubgroup(shardNames: const <String>[
'cross-arm64-vm-linux-release-be',
], testSteps: const <String>[
- '', // This subgroup triggers other tests.
+ // This subgroup triggers other tests.
]),
const BuildSubgroup(shardNames: const <String>[
'vm-linux-release-ia32-asan-be',
@@ -323,18 +323,17 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-linux-d8-hostchecked-unittest-4-5-be',
'dart2js-linux-d8-hostchecked-unittest-5-5-be',
], testSteps: const <String>[
- 'dart2js d8 tests',
- 'dart2js d8 package tests',
- 'dart2js d8 observatory_ui tests',
- 'dart2js d8 co19 tests',
- 'dart2js d8 extra tests',
- 'dart2js d8 try tests',
- 'dart2js d8 checked tests',
- 'dart2js d8 package checked tests',
- 'dart2js d8 observatory_ui checked tests',
- 'dart2js d8 co19 checked tests',
- 'dart2js d8 extra checked tests',
- 'dart2js d8 try checked tests',
+ 'dart2js-d8 tests',
+ 'dart2js-d8-package tests',
+ 'dart2js-d8-observatory-ui tests',
+ 'dart2js-d8-co19 tests',
+ 'dart2js-d8-extra tests',
+ 'dart2js-d8-checked tests',
+ 'dart2js-d8-package-checked tests',
+ 'dart2js-d8-observatory-ui-checked tests',
+ 'dart2js-d8-co19-checked tests',
+ 'dart2js-d8-extra-checked tests',
+ 'dart2js-unit tests',
]),
],
),
@@ -348,22 +347,22 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-linux-d8-minified-4-5-be',
'dart2js-linux-d8-minified-5-5-be',
], testSteps: const <String>[
- 'dart2js d8 tests',
- 'dart2js d8 observatory_ui tests',
- 'dart2js d8 package tests',
- 'dart2js d8 co19 tests',
- 'dart2js d8 extra tests',
- 'dart2js-with-kernel d8 tests',
- 'dart2js d8 fast-startup tests',
- 'dart2js d8 observatory_ui fast-startup tests',
- 'dart2js d8 package fast-startup tests',
- 'dart2js d8 co19 fast-startup tests',
- 'dart2js d8 extra fast-startup tests',
- 'dart2js d8 fast-startup checked tests',
- 'dart2js d8 observatory_ui fast-startup checked tests',
- 'dart2js d8 package fast-startup checked tests',
- 'dart2js d8 co19 fast-startup checked tests',
- 'dart2js d8 extra fast-startup checked tests',
+ 'dart2js-d8 tests',
+ 'dart2js-d8-observatory_ui tests',
+ 'dart2js-d8-package tests',
+ 'dart2js-d8-co19 tests',
+ 'dart2js-d8-extra tests',
+ 'dart2js-with-kernel-d8 tests',
+ 'dart2js-d8-fast-startup tests',
+ 'dart2js-d8-observatory_ui-fast-startup tests',
+ 'dart2js-d8-package-fast-startup tests',
+ 'dart2js-d8-co19-fast-startup tests',
+ 'dart2js-d8-extra-fast-startup tests',
+ 'dart2js-d8-fast-startup-checked tests',
+ 'dart2js-d8-observatory_ui-fast-startup-checked tests',
+ 'dart2js-d8-package-fast-startup-checked tests',
+ 'dart2js-d8-co19-fast-startup-checked tests',
+ 'dart2js-d8-extra-fast-startup-checked tests',
])
],
),
@@ -376,17 +375,16 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-linux-jsshell-3-4-be',
'dart2js-linux-jsshell-4-4-be',
], testSteps: const <String>[
- 'dart2js unit tests',
- 'dart2js jsshell tests',
- 'dart2js jsshell observatory_ui tests',
- 'dart2js jsshell package tests',
- 'dart2js jsshell co19 tests',
- 'dart2js jsshell extra tests',
- 'dart2js jsshell fast-startup tests',
- 'dart2js jsshell observatory_ui fast-startup tests',
- 'dart2js jsshell package fast-startup tests',
- 'dart2js jsshell co19 fast-startup tests',
- 'dart2js jsshell extra fast-startup tests',
+ 'dart2js-jsshell tests',
+ 'dart2js-jsshell-observatory_ui tests',
+ 'dart2js-jsshell-package tests',
+ 'dart2js-jsshell-co19 tests',
+ 'dart2js-jsshell-extra tests',
+ 'dart2js-jsshell-fast-startup tests',
+ 'dart2js-jsshell-observatory_ui-fast-startup tests',
+ 'dart2js-jsshell-package-fast-startup tests',
+ 'dart2js-jsshell-co19-fast-startup tests',
+ 'dart2js-jsshell-extra-fast-startup tests',
])
],
),
@@ -494,13 +492,13 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart-sdk-windows-be',
'dart-sdk-mac-be',
], testSteps: const <String>[
- 'generate_sdks',
+ // This subgroup triggers other tests.
]),
const BuildSubgroup(shardNames: const <String>[
'sdk-trigger-be',
], testSteps: const <String>[
- '', // This subgroup triggers other tests.
- ]),
+ // This subgroup triggers other tests.
+ ], isActive: false),
],
),
const BuildGroup(
@@ -515,7 +513,7 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'drt_layout_checked_tests',
'dartium_core_unchecked_tests',
'dartium_core_checked_tests',
- ]),
+ ], isActive: false),
],
),
const BuildGroup(
@@ -527,26 +525,26 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-linux-chromeff-3-4-be',
'dart2js-linux-chromeff-4-4-be'
], testSteps: const <String>[
- 'dart2js chrome tests',
- 'dart2js chrome observatory_ui tests',
- 'dart2js chrome package tests',
- 'dart2js chrome co19 tests',
- 'dart2js chrome extra tests',
- 'dart2js chrome fast-startup tests',
- 'dart2js chrome observatory_ui fast-startup tests',
- 'dart2js chrome package fast-startup tests',
- 'dart2js chrome co19 fast-startup tests',
- 'dart2js chrome extra fast-startup tests',
- 'dart2js ff tests',
- 'dart2js ff observatory_ui tests',
- 'dart2js ff package tests',
- 'dart2js ff co19 tests',
- 'dart2js ff extra tests',
- 'dart2js ff fast-startup tests',
- 'dart2js ff observatory_ui fast-startup tests',
- 'dart2js ff package fast-startup tests',
- 'dart2js ff co19 fast-startup tests',
- 'dart2js ff extra fast-startup tests',
+ 'dart2js-chrome tests',
+ 'dart2js-chrome-observatory_ui tests',
+ 'dart2js-chrome-package tests',
+ 'dart2js-chrome-co19 tests',
+ 'dart2js-chrome-extra tests',
+ 'dart2js-chrome-fast-startup tests',
+ 'dart2js-chrome-observatory_ui-fast-startup tests',
+ 'dart2js-chrome-package-fast-startup tests',
+ 'dart2js-chrome-co19-fast-startup tests',
+ 'dart2js-chrome-extra-fast-startup tests',
+ 'dart2js-ff tests',
+ 'dart2js-ff-observatory_ui tests',
+ 'dart2js-ff-package tests',
+ 'dart2js-ff-co19 tests',
+ 'dart2js-ff-extra tests',
+ 'dart2js-ff-fast-startup tests',
+ 'dart2js-ff-observatory_ui-fast-startup tests',
+ 'dart2js-ff-package-fast-startup tests',
+ 'dart2js-ff-co19-fast-startup tests',
+ 'dart2js-ff-extra-fast-startup tests',
]),
],
),
@@ -558,35 +556,35 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-linux-drt-2-2-be',
'dart2js-linux-drt-csp-minified-be'
], testSteps: const <String>[
- 'dart2js drt tests',
- 'dart2js drt observatory_ui tests',
- 'dart2js drt package tests',
- 'dart2js drt co19 tests',
- 'dart2js drt extra tests',
- 'dart2js drt fast-startup tests',
- 'dart2js drt observatory_ui fast-startup tests',
- 'dart2js drt package fast-startup tests',
- 'dart2js drt co19 fast-startup tests',
- 'dart2js drt extra fast-startup tests',
- 'dart2js drt fast-startup checked tests',
- 'dart2js drt observatory_ui fast-startup checked tests',
- 'dart2js drt package fast-startup checked tests',
- 'dart2js drt co19 fast-startup checked tests',
- 'dart2js drt extra fast-startup checked tests',
+ 'dart2js-drt tests',
+ 'dart2js-drt-observatory_ui tests',
+ 'dart2js-drt-package tests',
+ 'dart2js-drt-co19 tests',
+ 'dart2js-drt-extra tests',
+ 'dart2js-drt-fast-startup tests',
+ 'dart2js-drt-observatory_ui-fast-startup tests',
+ 'dart2js-drt-package-fast-startup tests',
+ 'dart2js-drt-co19-fast-startup tests',
+ 'dart2js-drt-extra-fast-startup tests',
+ 'dart2js-drt-fast-startup-checked tests',
+ 'dart2js-drt-observatory_ui-fast-startup-checked tests',
+ 'dart2js-drt-package-fast-startup-checked tests',
+ 'dart2js-drt-co19-fast-startup-checked tests',
+ 'dart2js-drt-extra-fast-startup-checked tests',
]),
const BuildSubgroup(shardNames: const <String>[
'dart2js-mac10.11-chrome-be'
], testSteps: const <String>[
- 'dart2js chrome tests',
- 'dart2js chrome observatory_ui tests',
- 'dart2js chrome package tests',
- 'dart2js chrome co19 tests',
- 'dart2js chrome extra tests',
- 'dart2js chrome fast-startup tests',
- 'dart2js chrome observatory_ui fast-startup tests',
- 'dart2js chrome package fast-startup tests',
- 'dart2js chrome co19 fast-startup tests',
- 'dart2js chrome extra fast-startup tests',
+ 'dart2js-chrome tests',
+ 'dart2js-chrome-observatory_ui tests',
+ 'dart2js-chrome-package tests',
+ 'dart2js-chrome-co19 tests',
+ 'dart2js-chrome-extra tests',
+ 'dart2js-chrome-fast-startup tests',
+ 'dart2js-chrome-observatory_ui-fast-startup tests',
+ 'dart2js-chrome-package-fast-startup tests',
+ 'dart2js-chrome-co19-fast-startup tests',
+ 'dart2js-chrome-extra-fast-startup tests',
]),
],
),
@@ -598,16 +596,16 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-mac10.11-safari-2-3-be',
'dart2js-mac10.11-safari-3-3-be'
], testSteps: const <String>[
- 'dart2js safari tests',
- 'dart2js safari observatory_ui tests',
- 'dart2js safari package tests',
- 'dart2js safari co19 tests',
- 'dart2js safari extra tests',
- 'dart2js safari fast-startup tests',
- 'dart2js safari observatory_ui fast-startup tests',
- 'dart2js safari package fast-startup tests',
- 'dart2js safari co19 fast-startup tests',
- 'dart2js safari extra fast-startup tests',
+ 'dart2js-safari tests',
+ 'dart2js-safari-observatory_ui tests',
+ 'dart2js-safari-package tests',
+ 'dart2js-safari-co19 tests',
+ 'dart2js-safari-extra tests',
+ 'dart2js-safari-fast-startup tests',
+ 'dart2js-safari-observatory_ui-fast-startup tests',
+ 'dart2js-safari-package-fast-startup tests',
+ 'dart2js-safari-co19-fast-startup tests',
+ 'dart2js-safari-extra-fast-startup tests',
]),
],
),
@@ -619,16 +617,16 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
], testSteps: const <String>[
'dart2js ie10 tests',
'dart2js ie10 co19 tests',
- 'dart2js ie10 fast-startup tests',
- 'dart2js ie10 co19 fast-startup tests',
+ 'dart2js ie10-fast-startup tests',
+ 'dart2js ie10 co19-fast-startup tests',
], isActive: false),
const BuildSubgroup(shardNames: const <String>[
'dart2js-win8-ie11-be'
], testSteps: const <String>[
'dart2js ie11 tests',
'dart2js ie11 co19 tests',
- 'dart2js ie11 fast-startup tests',
- 'dart2js ie11 co19 fast-startup tests',
+ 'dart2js ie11-fast-startup tests',
+ 'dart2js ie11 co19-fast-startup tests',
], isActive: false),
],
),
@@ -659,8 +657,8 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
], testSteps: const <String>[
'dart2js ie11 tests',
'dart2js ie11 co19 tests',
- 'dart2js ie11 fast-startup tests',
- 'dart2js ie11 co19 fast-startup tests',
+ 'dart2js ie11-fast-startup tests',
+ 'dart2js ie11 co19-fast-startup tests',
]),
const BuildSubgroup(shardNames: const <String>[
'dart2js-win7-chrome-1-4-be',
@@ -668,16 +666,16 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dart2js-win7-chrome-3-4-be',
'dart2js-win7-chrome-4-4-be'
], testSteps: const <String>[
- 'dart2js chrome tests',
- 'dart2js chrome observatory_ui tests',
- 'dart2js chrome package tests',
- 'dart2js chrome co19 tests',
- 'dart2js chrome extra tests',
- 'dart2js chrome fast-startup tests',
- 'dart2js chrome observatory_ui fast-startup tests',
- 'dart2js chrome package fast-startup tests',
- 'dart2js chrome co19 fast-startup tests',
- 'dart2js chrome extra fast-startup tests',
+ 'dart2js-chrome tests',
+ 'dart2js-chrome-observatory_ui tests',
+ 'dart2js-chrome-package tests',
+ 'dart2js-chrome-co19 tests',
+ 'dart2js-chrome-extra tests',
+ 'dart2js-chrome-fast-startup tests',
+ 'dart2js-chrome-observatory_ui-fast-startup tests',
+ 'dart2js-chrome-package-fast-startup tests',
+ 'dart2js-chrome-co19-fast-startup tests',
+ 'dart2js-chrome-extra-fast-startup tests',
]),
const BuildSubgroup(shardNames: const <String>[
'dart2js-win7-ie11ff-1-4-be',
@@ -687,18 +685,18 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
], testSteps: const <String>[
'dart2js ie11 tests',
'dart2js ie11 co19 tests',
- 'dart2js ie11 fast-startup tests',
- 'dart2js ie11 co19 fast-startup tests',
- 'dart2js ff tests',
- 'dart2js ff observatory_ui tests',
- 'dart2js ff package tests',
- 'dart2js ff co19 tests',
- 'dart2js ff extra tests',
- 'dart2js ff fast-startup tests',
- 'dart2js ff observatory_ui fast-startup tests',
- 'dart2js ff package fast-startup tests',
- 'dart2js ff co19 fast-startup tests',
- 'dart2js ff extra fast-startup tests',
+ 'dart2js ie11-fast-startup tests',
+ 'dart2js ie11 co19-fast-startup tests',
+ 'dart2js-ff tests',
+ 'dart2js-ff-observatory_ui tests',
+ 'dart2js-ff-package tests',
+ 'dart2js-ff-co19 tests',
+ 'dart2js-ff-extra tests',
+ 'dart2js-ff-fast-startup tests',
+ 'dart2js-ff-observatory_ui-fast-startup tests',
+ 'dart2js-ff-package-fast-startup tests',
+ 'dart2js-ff-co19-fast-startup tests',
+ 'dart2js-ff-extra-fast-startup tests',
]),
],
),
@@ -742,17 +740,17 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'dartium-linux-x64-be',
], testSteps: const <String>[
'annotated steps',
- ]),
+ ], isActive: false),
const BuildSubgroup(shardNames: const <String>[
'dartium-mac-x64-be',
], testSteps: const <String>[
'annotated steps',
- ]),
+ ], isActive: false),
const BuildSubgroup(shardNames: const <String>[
'dartium-win-ia32-be',
], testSteps: const <String>[
'annotated steps',
- ]),
+ ], isActive: false),
],
),
const BuildGroup(
@@ -760,14 +758,10 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
subgroups: const <BuildSubgroup>[
const BuildSubgroup(shardNames: const <String>[
'versionchecker-linux-be',
- ], testSteps: const <String>[
- 'annotated_steps',
- ]),
+ ], testSteps: const <String>[]),
const BuildSubgroup(shardNames: const <String>[
'debianpackage-linux-be',
- ], testSteps: const <String>[
- 'annotated_steps',
- ]),
+ ], testSteps: const <String>[]),
],
),
const BuildGroup(
« no previous file with comments | « no previous file | tools/gardening/lib/src/buildbot_loading.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698