Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2986133002: Suggest covariant in parameter lists (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-07-28 17:19:28 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-07-28 17:21:52 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-07-28 17:33:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b88eef0afa0e8293deeb15f567ffb9c4ebba994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698