Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart

Issue 2986133002: Suggest covariant in parameter lists (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart
index c11cce80ea1151dd42b33e3d1d1b651daa7623ea..083203e61467e97ceff176dea57efadca531ec19 100644
--- a/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart
@@ -805,13 +805,13 @@ class KeywordContributorTest extends DartCompletionContributorTest {
test_constructor_param() async {
addTestSource('class A { A(^) {});}');
await computeSuggestions();
- assertSuggestKeywords([Keyword.THIS]);
+ assertSuggestKeywords([Keyword.COVARIANT, Keyword.THIS]);
}
test_constructor_param2() async {
addTestSource('class A { A(t^) {});}');
await computeSuggestions();
- assertSuggestKeywords([Keyword.THIS]);
+ assertSuggestKeywords([Keyword.COVARIANT, Keyword.THIS]);
}
test_do_break_continue() async {
@@ -1564,13 +1564,15 @@ class A {
test_method_param() async {
addTestSource('class A { foo(^) {});}');
await computeSuggestions();
- expect(suggestions, isEmpty);
+ expect(suggestions, isNotEmpty);
+ assertSuggestKeywords([Keyword.COVARIANT]);
}
test_method_param2() async {
addTestSource('class A { foo(t^) {});}');
await computeSuggestions();
- expect(suggestions, isEmpty);
+ expect(suggestions, isNotEmpty);
+ assertSuggestKeywords([Keyword.COVARIANT]);
}
test_method_param_named_init() async {
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698