Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2986033002: Revert of Always prefer 192x192 on mobile, also for touch icons (Closed)

Created:
3 years, 4 months ago by mastiz
Modified:
3 years, 4 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always prefer 192x192 on mobile, also for touch icons (patchset #2 id:20001 of https://codereview.chromium.org/2972643002/ ) Reason for revert: Perf regression, suspect of accidentally fixing a bug that was believed to be previously fixed (crbug.com/735354) due to the max image size used during download. BUG=749331 Original issue's description: > Always prefer 192x192 on mobile, also for touch icons > > Previously, the ideal size for a touch icon was 144x144, which was > originally introduced honoring iPad icon size. > > Always going for 192x192 (for both touch and non-touch icons) is > simpler, more consistent and more compatible with Apple's current > recommendations for iOS [1], which for example recommend a 180x180 icon > for iPhone 6 Plus (scale factor of 3x). > > [1] https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > > BUG=736290 > > Review-Url: https://codereview.chromium.org/2972643002 > Cr-Commit-Position: refs/heads/master@{#488935} > Committed: https://chromium.googlesource.com/chromium/src/+/c63d78c7a25a50f2fdfa0ab5cbb5566a21a6774e TBR=pkotwicz@chromium.org,noyau@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=736290 Review-Url: https://codereview.chromium.org/2986033002 Cr-Commit-Position: refs/heads/master@{#489971} Committed: https://chromium.googlesource.com/chromium/src/+/195ee4a01e7dfb6a1a13a32e01526464e7715f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M components/favicon/core/favicon_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/favicon/core/favicon_handler.cc View 5 chunks +17 lines, -9 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mastiz
Created Revert of Always prefer 192x192 on mobile, also for touch icons
3 years, 4 months ago (2017-07-27 15:29:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2986033002/1
3 years, 4 months ago (2017-07-27 15:30:07 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 16:40:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/195ee4a01e7dfb6a1a13a32e0152...

Powered by Google App Engine
This is Rietveld 408576698