Chromium Code Reviews
DescriptionRevert of Always prefer 192x192 on mobile, also for touch icons (patchset #2 id:20001 of https://codereview.chromium.org/2972643002/ )
Reason for revert:
Perf regression, suspect of accidentally fixing a bug that was believed to be previously fixed (crbug.com/735354) due to the max image size used during download.
BUG=749331
Original issue's description:
> Always prefer 192x192 on mobile, also for touch icons
>
> Previously, the ideal size for a touch icon was 144x144, which was
> originally introduced honoring iPad icon size.
>
> Always going for 192x192 (for both touch and non-touch icons) is
> simpler, more consistent and more compatible with Apple's current
> recommendations for iOS [1], which for example recommend a 180x180 icon
> for iPhone 6 Plus (scale factor of 3x).
>
> [1] https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/
>
> BUG=736290
>
> Review-Url: https://codereview.chromium.org/2972643002
> Cr-Commit-Position: refs/heads/master@{#488935}
> Committed: https://chromium.googlesource.com/chromium/src/+/c63d78c7a25a50f2fdfa0ab5cbb5566a21a6774e
TBR=pkotwicz@chromium.org,noyau@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=736290
Review-Url: https://codereview.chromium.org/2986033002
Cr-Commit-Position: refs/heads/master@{#489971}
Committed: https://chromium.googlesource.com/chromium/src/+/195ee4a01e7dfb6a1a13a32e01526464e7715f12
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
|||||||||||||||||||||||||||||||||||||