Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2985993002: isolate: Pull isolated file handling into its own type. (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: Pull isolated file handling into its own type. BUG=692940 Review-Url: https://codereview.chromium.org/2985993002 Committed: https://github.com/luci/luci-go/commit/1bb9e0cd284747048ec3ce359ffcaa1fc3032016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M client/cmd/isolate/upload_tracker.go View 2 chunks +53 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mithro
LGTM
3 years, 4 months ago (2017-07-27 06:11:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985993002/1
3 years, 4 months ago (2017-07-27 06:12:37 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 06:25:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/1bb9e0cd284747048ec3ce359ffcaa1fc3032016

Powered by Google App Engine
This is Rietveld 408576698