Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2985903002: config_service: Removed hotlist from feedback link. (Closed)

Created:
3 years, 4 months ago by cwpayton
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: Removed hotlist from feedback link. Since our hotlist is not publicly writable, we need to remove the hotlist from the feedback link BUG=748828 Review-Url: https://codereview.chromium.org/2985903002 Committed: https://github.com/luci/luci-py/commit/b814755395f4379d6e95f06223edd8b135f46591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M appengine/config_service/ui/static/index.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cwpayton
PTAL
3 years, 4 months ago (2017-07-26 16:06:02 UTC) #2
Sergey Berezin
LGTM + CQ, thanks! Let's deploy this ASAP.
3 years, 4 months ago (2017-07-26 18:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985903002/1
3 years, 4 months ago (2017-07-26 18:35:17 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 18:38:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/b814755395f4379d6e95f06223edd8b135f46591

Powered by Google App Engine
This is Rietveld 408576698