Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2985873002: Pass a Writer to Finalize for JSON dumping. (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Pass a Writer to Finalize for JSON dumping. For testability. BUG=692940 Review-Url: https://codereview.chromium.org/2985873002 Committed: https://github.com/luci/luci-go/commit/7869f7ebdc61a95a8fbdb62a6df904497159704e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M client/cmd/isolate/exp_archive.go View 2 chunks +14 lines, -1 line 0 comments Download
M client/cmd/isolate/upload_tracker.go View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 4 months ago (2017-07-26 05:14:45 UTC) #2
mithro
LGTM! This is a great way to solve the problem we were discussing.
3 years, 4 months ago (2017-07-26 05:34:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985873002/1
3 years, 4 months ago (2017-07-27 05:57:27 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 06:04:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/7869f7ebdc61a95a8fbdb62a6df904497159704e

Powered by Google App Engine
This is Rietveld 408576698