Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: appengine/swarming/server/task_scheduler_test.py

Issue 2985753003: swarming: Remove support for task without 'pool' dimension (Closed)
Patch Set: Tweak comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/server/task_scheduler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/server/task_scheduler_test.py
diff --git a/appengine/swarming/server/task_scheduler_test.py b/appengine/swarming/server/task_scheduler_test.py
index 93e8e804458142b4746efde8be21e13d0158bba3..2cb43960d5ef1c92aa5b8744347c9598fc135e8e 100755
--- a/appengine/swarming/server/task_scheduler_test.py
+++ b/appengine/swarming/server/task_scheduler_test.py
@@ -15,6 +15,7 @@ APP_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, APP_DIR)
import test_env_handlers
+from google.appengine.api import datastore_errors
from google.appengine.ext import ndb
import webtest
@@ -710,10 +711,11 @@ class TaskSchedulerApiTest(test_env_handlers.AppTestBase):
def test_schedule_request_id_without_pool(self):
self.mock_dim_acls({u'pool:good': u'mocked'})
- with self.assertRaises(auth.AuthorizationError):
+ with self.assertRaises(datastore_errors.BadValueError):
self._quick_schedule(properties={'dimensions': {u'id': u'abc'}})
auth_testing.mock_is_admin(self)
- self._quick_schedule(properties={'dimensions': {u'id': u'abc'}}, nb_task=0)
+ with self.assertRaises(datastore_errors.BadValueError):
+ self._quick_schedule(properties={'dimensions': {u'id': u'abc'}})
def test_schedule_request_id_and_pool(self):
self.mock_dim_acls({u'pool:good': u'mocked'})
« no previous file with comments | « appengine/swarming/server/task_scheduler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698