Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2985613002: Revert of Handle Java assert using a customized function in base (Closed)

Created:
3 years, 5 months ago by estevenson
Modified:
3 years, 5 months ago
Reviewers:
F, Ran, Yaron, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, danakj+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Handle Java assert using a customized function in base (patchset #11 id:470001 of https://codereview.chromium.org/2971063003/ ) Reason for revert: Reland changes weren't reviewed Original issue's description: > Create java_assertion_handler, a Java binary that takes in a JAR file > and modifies the bytecode of classes. > > Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler > that throws Exception. > > Output is written to a new JAR file. > > > BUG=672945 > > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Original-Commit-Position: refs/heads/master@{#487903} > Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589 > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Commit-Position: refs/heads/master@{#488381} > Committed: https://chromium.googlesource.com/chromium/src/+/bef3daf02ae6035f166782025fd7e4e54d465271 TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672945 Review-Url: https://codereview.chromium.org/2985613002 Cr-Commit-Position: refs/heads/master@{#488390} Committed: https://chromium.googlesource.com/chromium/src/+/83b7815399e50c9f9da3434669eba2829c2857e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -173 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/JavaExceptionReporter.java View 2 chunks +0 lines, -11 lines 0 comments Download
M base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
D build/android/buildhooks/java/org/chromium/buildhooks/BuildHooks.java View 1 chunk +0 lines, -26 lines 0 comments Download
D build/android/buildhooks/java/org/chromium/buildhooks/Callback.java View 1 chunk +0 lines, -10 lines 0 comments Download
M build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java View 5 chunks +36 lines, -90 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 6 chunks +14 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/shell_apk/shell_apk_version.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
estevenson
Created Revert of Handle Java assert using a customized function in base
3 years, 5 months ago (2017-07-20 20:35:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985613002/1
3 years, 5 months ago (2017-07-20 20:35:31 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 20:36:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83b7815399e50c9f9da3434669eb...

Powered by Google App Engine
This is Rietveld 408576698