Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2985493002:
config_service: README update (Closed)
|
Created:
3 years, 5 months ago by ayanaadylova Modified:
3 years, 5 months ago CC:
chromium-reviews, infra-reviews+luci-py_chromium.org Target Ref:
refs/heads/master Project:
luci-py Visibility:
Public. |
Descriptionconfig_service: README update
Updated README.md file inside ui folder.
BUG=730832
Review-Url: https://codereview.chromium.org/2985493002
Committed: https://github.com/luci/luci-py/commit/f16285c26e156183e6b896b6fa1966c4491fc70c
Patch Set 1 #
Total comments: 8
Patch Set 2 : Change README #
Total comments: 2
Messages
Total messages: 14 (8 generated)
Description was changed from ========== README update Updated README.md file inside ui folder. BUG=730832 ========== to ========== README update Updated README.md file inside ui folder. BUG=730832 ==========
Description was changed from ========== README update Updated README.md file inside ui folder. BUG=730832 ========== to ========== config_service: README update Updated README.md file inside ui folder. BUG=730832 ==========
ayanaadylova@google.com changed reviewers: + hinoka@chromium.org, sergeyberezin@chromium.org
PTAL
hinoka@google.com changed reviewers: + hinoka@google.com
lgtm + comments https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... File appengine/config_service/ui/README.md (right): https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:6: ## Setting up I think the appengine SDK also needs to be installed for dev_appserver.py, correct? https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:10: * Run 'bower install' to make sure you have all the dependecies installed. in which directory? Also use backtick ` instead of quotes ' for code. https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:16: * One in the src/config-ui/front-page.html ** instead of <tab>* https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:19: * In the config-service folder run 'dev_appserver.py app.yaml' `dev_appserver.py app.yaml` it's a backtick instead of a quote
https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... File appengine/config_service/ui/README.md (right): https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:6: ## Setting up On 2017/07/19 20:53:36, Ryan Tseng wrote: > I think the appengine SDK also needs to be installed for dev_appserver.py, > correct? Done. https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:10: * Run 'bower install' to make sure you have all the dependecies installed. On 2017/07/19 20:53:36, Ryan Tseng wrote: > in which directory? > > Also use backtick ` instead of quotes ' for code. Done. https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:16: * One in the src/config-ui/front-page.html On 2017/07/19 20:53:36, Ryan Tseng wrote: > ** instead of <tab>* ** doesn't work, so I used <tab>* instead. https://codereview.chromium.org/2985493002/diff/1/appengine/config_service/ui... appengine/config_service/ui/README.md:19: * In the config-service folder run 'dev_appserver.py app.yaml' On 2017/07/19 20:53:36, Ryan Tseng wrote: > `dev_appserver.py app.yaml` > > it's a backtick instead of a quote Done.
The CQ bit was checked by ayanaadylova@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@google.com Link to the patchset: https://codereview.chromium.org/2985493002/#ps20001 (title: "Change README")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500498832528410,
"parent_rev": "fab15c293edc757132bc84067ae69fa8ca934756", "commit_rev":
"f16285c26e156183e6b896b6fa1966c4491fc70c"}
Message was sent while issue was closed.
Description was changed from ========== config_service: README update Updated README.md file inside ui folder. BUG=730832 ========== to ========== config_service: README update Updated README.md file inside ui folder. BUG=730832 Review-Url: https://codereview.chromium.org/2985493002 Committed: https://github.com/luci/luci-py/commit/f16285c26e156183e6b896b6fa1966c4491fc70c ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/f16285c26e156183e6b896b6fa1966c4491fc70c
Message was sent while issue was closed.
LGTM + a couple of comments for another CL. Thanks! https://codereview.chromium.org/2985493002/diff/20001/appengine/config_servic... File appengine/config_service/ui/README.md (right): https://codereview.chromium.org/2985493002/diff/20001/appengine/config_servic... appengine/config_service/ui/README.md:12: * Run `bower install` in the ui directory to make sure you have all the dependecies installed. dependencies (spelling) https://codereview.chromium.org/2985493002/diff/20001/appengine/config_servic... appengine/config_service/ui/README.md:29: Run 'wct, 'wct -p' or 'polymer test' inside ui folder to run your application's test suites locally. `wct` (backtick, and missing the closing one) `wct -p` or `polymer test` (more backticks) |
