Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Issue 2985453003: fix shelf color with modal dialog. (Closed)

Created:
3 years, 5 months ago by Muyuan
Modified:
3 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fix shelf color with modal dialog. BUG=745343 TEST=Open save pdf dialog and observe that shelf does not change color. Review-Url: https://codereview.chromium.org/2985453003 Cr-Commit-Position: refs/heads/master@{#489725} Committed: https://chromium.googlesource.com/chromium/src/+/639b61ae53bb47d9de383cec09024c2150f2d47b

Patch Set 1 #

Patch Set 2 : [WIP not ready for review] This patchset is to save a snapshot.. #

Patch Set 3 : add test #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M ash/wm/focus_rules.cc View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Muyuan
3 years, 5 months ago (2017-07-19 21:14:22 UTC) #2
oshima
can you add a unit test?
3 years, 5 months ago (2017-07-19 21:54:20 UTC) #3
Muyuan
On 2017/07/19 21:54:20, oshima wrote: > can you add a unit test? done
3 years, 5 months ago (2017-07-25 03:07:14 UTC) #4
oshima
lgtm thanks!
3 years, 5 months ago (2017-07-25 03:17:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985453003/40001
3 years, 5 months ago (2017-07-25 04:05:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985453003/40001
3 years, 5 months ago (2017-07-25 05:13:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/475765)
3 years, 5 months ago (2017-07-25 06:58:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985453003/60001
3 years, 4 months ago (2017-07-26 18:55:18 UTC) #15
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 19:37:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/639b61ae53bb47d9de383cec0902...

Powered by Google App Engine
This is Rietveld 408576698