Issue 2985333002: fix #30290, assertion messages that contain `yield`

Issue 2985333002: fix #30290, assertion messages that contain `yield` (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly

Modified:
3 years, 4 months ago

Reviewers:
vsm, Bob Nystrom

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

fix #30290, assertion messages that contain `yield` also fixes list_sort_test to work in strong mode. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/d705cff08ee563e463d4ed62e8e0c9eb29586086

Created: 3 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -38 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	1 2 3	Binary file		0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 2 3	1 chunk	+9 lines, -8 lines	0 comments	Download
M	pkg/dev_compiler/test-main.js	View	1 2 3	2 chunks	+3 lines, -8 lines	0 comments	Download
M	pkg/dev_compiler/test/browser/language_tests.js	View	1 2 3	5 chunks	+2 lines, -4 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart	View	1 2 3	1 chunk	+2 lines, -10 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib_strong/sort_helper.dart	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

this is a follow up to my recent CL fixing DDC's travis bot status.

3 years, 4 months ago (2017-07-29 00:59:39 UTC) #2

Jennifer Messerly

3 years, 4 months ago (2017-07-31 21:20:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:30001) manually as
d705cff08ee563e463d4ed62e8e0c9eb29586086 (presubmit successful).