pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart - Issue 2985333002: fix #30290, assertion messages that contain `yield`

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

Issue 2985333002: fix #30290, assertion messages that contain `yield` (Closed)

Patch Set: merge and update status Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

index 79a01db5182789cb45778ee0f1f784b27a6b37ee..b2b982a19928b24dbdc69e76e0ae5a357ead6115 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

@@ -73,9 +73,8 @@ throwUnimplementedError(String message) {

throw new UnimplementedError(message);

}

-throwAssertionError(messageFn()) {

+assertFailed(message) {

if (JS('bool', 'dart.__trapRuntimeErrors')) JS('', 'debugger');

- var message = messageFn != null ? messageFn() : null;

throw new AssertionErrorImpl(message);

}