Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2985313002:
Disable testSmokeStartingWebPageReplayGoServer on chromeos. (Closed)
DescriptionDisable testSmokeStartingWebPageReplayGoServer on chromeos.
Error:
NoPathFoundError: No file could be found locally, and no file to
download from cloud storage for example_domain_wpr_go_archive on
platform chromeos_x86_64
BUG=chromium:750323
TEST=manual
Review-Url: https://codereview.chromium.org/2985313002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/33a9271eb3cf5caf925293ec6a4b47c94f1ac968
Patch Set 1 #
Total comments: 1
Messages
Total messages: 26 (8 generated)
achuith@chromium.org changed reviewers: + nednguyen@google.com, xunjieli@chromium.org
Ptal, Helen and Ned.
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/28 20:37:04, achuithb wrote: > Ptal, Helen and Ned. We should need to make this test pass on chromeOS, otherwise wprgo conversion will fail. Is ChromeOS basically just linux?
On 2017/07/28 20:37:04, achuithb wrote: > Ptal, Helen and Ned. Can we fix this by just using the Linux binary?
On 2017/07/28 20:37:48, nednguyen wrote: > On 2017/07/28 20:37:04, achuithb wrote: > > Ptal, Helen and Ned. > > We should need to make this test pass on chromeOS, otherwise wprgo conversion > will fail. Is ChromeOS basically just linux? Yup, it is linux.
On 2017/07/28 20:39:22, achuithb wrote: > On 2017/07/28 20:37:48, nednguyen wrote: > > On 2017/07/28 20:37:04, achuithb wrote: > > > Ptal, Helen and Ned. > > > > We should need to make this test pass on chromeOS, otherwise wprgo conversion > > will fail. Is ChromeOS basically just linux? > > Yup, it is linux. Can you update the code in https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/... so use 'linux' if py_utils.GetHostOsName() return 'chromeos'?
On 2017/07/28 20:39:22, achuithb wrote: > On 2017/07/28 20:37:48, nednguyen wrote: > > On 2017/07/28 20:37:04, achuithb wrote: > > > Ptal, Helen and Ned. > > > > We should need to make this test pass on chromeOS, otherwise wprgo conversion > > will fail. Is ChromeOS basically just linux? > > Yup, it is linux. https://goto.google.com/cros-vm Launch a chromeos VM, you can either login to the VM and run this unittest there, or run it remotely.
On 2017/07/28 20:41:37, achuithb wrote: > On 2017/07/28 20:39:22, achuithb wrote: > > On 2017/07/28 20:37:48, nednguyen wrote: > > > On 2017/07/28 20:37:04, achuithb wrote: > > > > Ptal, Helen and Ned. > > > > > > We should need to make this test pass on chromeOS, otherwise wprgo > conversion > > > will fail. Is ChromeOS basically just linux? > > > > Yup, it is linux. > > https://goto.google.com/cros-vm > > Launch a chromeos VM, you can either login to the VM and run this unittest > there, or run it remotely. Sorry, we are very swarmed. So it's better if you can help us verify the tests since you are more familiar with ChromeOS platform.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/07/28 20:41:30, nednguyen wrote: > On 2017/07/28 20:39:22, achuithb wrote: > > On 2017/07/28 20:37:48, nednguyen wrote: > > > On 2017/07/28 20:37:04, achuithb wrote: > > > > Ptal, Helen and Ned. > > > > > > We should need to make this test pass on chromeOS, otherwise wprgo > conversion > > > will fail. Is ChromeOS basically just linux? > > > > Yup, it is linux. > > Can you update the code in > https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/... > so use 'linux' if py_utils.GetHostOsName() return 'chromeos'? I tried this, and it didn't work. Here's the stack: [1/1] telemetry.internal.util.webpagereplay_go_server_unittest.WebPageReplayGoServerTest.testSmokeStartingWebPageReplayGoServer failed unexpectedly 0.0009s: Traceback (most recent call last): File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py", line 21, in setUp py_utils.GetHostOsName()) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/binary_manager.py", line 66, in FetchPath return _binary_manager.FetchPath(binary_name, os_name, arch, os_version) File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 38, in FetchPath os_version) File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 60, in _WrapDependencyManagerFunction return function(binary_name, platform) File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 130, in FetchPath path, _ = self.FetchPathWithVersion(dependency, platform) File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 89, in FetchPathWithVersion raise exceptions.NoPathFoundError(dependency, platform) NoPathFoundError: No file could be found locally, and no file to download from cloud storage for example_domain_wpr_go_archive on platform chromeos_x86_64 webpagereplay_go_server.py is not in the stack.
On 2017/07/28 20:42:20, nednguyen wrote: > On 2017/07/28 20:41:37, achuithb wrote: > > On 2017/07/28 20:39:22, achuithb wrote: > > > On 2017/07/28 20:37:48, nednguyen wrote: > > > > On 2017/07/28 20:37:04, achuithb wrote: > > > > > Ptal, Helen and Ned. > > > > > > > > We should need to make this test pass on chromeOS, otherwise wprgo > > conversion > > > > will fail. Is ChromeOS basically just linux? > > > > > > Yup, it is linux. > > > > https://goto.google.com/cros-vm > > > > Launch a chromeos VM, you can either login to the VM and run this unittest > > there, or run it remotely. > > Sorry, we are very swarmed. So it's better if you can help us verify the tests > since you are more familiar with ChromeOS platform. Is there any interest in the telemetry team in getting familiar with chromeos? I can help, but I don't think this is a good model going forward. I'm fully aware that we're missing trybots, etc, but you now do have the ability to run chromeos tests on your linux workstation, and I think more people should at least try it.
https://codereview.chromium.org/2985313002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py (right): https://codereview.chromium.org/2985313002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py:21: py_utils.GetHostOsName()) Can you also modify this to point to linux? I know Ned is super overloaded right now. I don't work on Telemetry.
On 2017/07/28 21:42:03, xunjieli wrote: > https://codereview.chromium.org/2985313002/diff/1/telemetry/telemetry/interna... > File telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py > (right): > > https://codereview.chromium.org/2985313002/diff/1/telemetry/telemetry/interna... > telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py:21: > py_utils.GetHostOsName()) > Can you also modify this to point to linux? > I know Ned is super overloaded right now. I don't work on Telemetry. Sure. It failed with CloudStorageIODisabled: Environment variable DISABLE_CLOUD_STORAGE_IO is set to 1. Command ['/usr/local/telemetry/src/third_party/catapult/third_party/gsutil/gsutil', 'cp', u'gs://chromium-telemetry/binary_dependencies/wpr_go_2d909ad1e83cb0fe9abf885400bbc24b78d330a2', u'/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/tmpl5OjH7'] is not allowed to run I then reverted this change: https://codereview.chromium.org/1843963002 Now the test passes.
On 2017/07/28 21:28:08, achuithb wrote: > On 2017/07/28 20:42:20, nednguyen wrote: > > On 2017/07/28 20:41:37, achuithb wrote: > > > On 2017/07/28 20:39:22, achuithb wrote: > > > > On 2017/07/28 20:37:48, nednguyen wrote: > > > > > On 2017/07/28 20:37:04, achuithb wrote: > > > > > > Ptal, Helen and Ned. > > > > > > > > > > We should need to make this test pass on chromeOS, otherwise wprgo > > > conversion > > > > > will fail. Is ChromeOS basically just linux? > > > > > > > > Yup, it is linux. > > > > > > https://goto.google.com/cros-vm > > > > > > Launch a chromeos VM, you can either login to the VM and run this unittest > > > there, or run it remotely. > > > > Sorry, we are very swarmed. So it's better if you can help us verify the tests > > since you are more familiar with ChromeOS platform. > > Is there any interest in the telemetry team in getting familiar with chromeos? I > can help, but I don't think this is a good model going forward. I'm fully aware > that we're missing trybots, etc, but you now do have the ability to run chromeos > tests on your linux workstation, and I think more people should at least try it. Feel free to book a meeting with me & Annie about this. Our team's staffing is too limited to also cover CrOs at the moment, so if CrOS teams think this is not working, we can consider other test framework.
Unfortunately this test is still failing for some reason: telemetry.internal.util.webpagereplay_go_server_unittest.WebPageReplayGoServerTest.testSmokeStartingWebPageReplayGoServer failed unexpectedly 0.0012s: 08/04 14:31:58.118 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 08/04 14:31:58.118 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py", line 20, in setUp 08/04 14:31:58.118 INFO |run_chromeos_tests:0052| py_utils.GetHostOsName()) 08/04 14:31:58.119 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/binary_manager.py", line 76, in FetchPath 08/04 14:31:58.119 INFO |run_chromeos_tests:0052| binary_name, _GetOSName(os_name), arch, os_version) 08/04 14:31:58.119 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 38, in FetchPath 08/04 14:31:58.120 INFO |run_chromeos_tests:0052| os_version) 08/04 14:31:58.120 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 60, in _WrapDependencyManagerFunction 08/04 14:31:58.120 INFO |run_chromeos_tests:0052| return function(binary_name, platform) 08/04 14:31:58.120 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 130, in FetchPath 08/04 14:31:58.121 INFO |run_chromeos_tests:0052| path, _ = self.FetchPathWithVersion(dependency, platform) 08/04 14:31:58.121 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 89, in FetchPathWithVersion 08/04 14:31:58.121 INFO |run_chromeos_tests:0052| raise exceptions.NoPathFoundError(dependency, platform) 08/04 14:31:58.121 INFO |run_chromeos_tests:0052| NoPathFoundError: No file could be found locally, and no file to download from cloud storage for example_domain_wpr_go_archive on platform linux_x86_64 The Histogram and ImageUtil tests that download bitmaputils now succeed. The error message shows that it's trying to download from linux_x86_64 which ought to succeed. The test also succeeds locally for me. This is the last holdout at this point, so I'd like to disable it so the bot has a chance to become green. I'll continue to investigate. Ned: could I get an lgtm?
lgtm But note that we are converting wpr archives to wprgo
On 2017/08/05 00:38:51, nednguyen wrote: > lgtm > > But note that we are converting wpr archives to wprgo Ok, hopefully I can figure out what's going on. It may be specific to example_domain_wpr_go_archive? Is there a benchmark I can run that uses wprgo?
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/08/05 00:41:47, achuithb wrote: > On 2017/08/05 00:38:51, nednguyen wrote: > > lgtm > > > > But note that we are converting wpr archives to wprgo > > Ok, hopefully I can figure out what's going on. It may be specific to > example_domain_wpr_go_archive? > > Is there a benchmark I can run that uses wprgo? You can see the list in https://docs.google.com/spreadsheets/d/1SVNzaT-bMIZ3nr6GZVXfLeoZIG59d635owASw... (@chromium account)
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1501893712375660, "parent_rev":
"46e88f15e528bc4a6e882d1123c2f1f9e695dd9a", "commit_rev":
"33a9271eb3cf5caf925293ec6a4b47c94f1ac968"}
Message was sent while issue was closed.
Description was changed from ========== Disable testSmokeStartingWebPageReplayGoServer on chromeos. Error: NoPathFoundError: No file could be found locally, and no file to download from cloud storage for example_domain_wpr_go_archive on platform chromeos_x86_64 BUG=chromium:750323 TEST=manual ========== to ========== Disable testSmokeStartingWebPageReplayGoServer on chromeos. Error: NoPathFoundError: No file could be found locally, and no file to download from cloud storage for example_domain_wpr_go_archive on platform chromeos_x86_64 BUG=chromium:750323 TEST=manual Review-Url: https://codereview.chromium.org/2985313002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
