Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2985203002: isolate: Move json dumping back into exparchive main (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: Move json dumping back into exparchive main We will use one UploadTracker per isolate in batch mode, and the dumped json will be based on the digests of multiple isolates. Therefore, json dumping should happen at a higher level. BUG=692940 Review-Url: https://codereview.chromium.org/2985203002 Committed: https://github.com/luci/luci-go/commit/29440f13003b1bf3464be6e4d65904e9ff7ad251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -35 lines) Patch
M client/cmd/isolate/exp_archive.go View 4 chunks +22 lines, -11 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 4 chunks +20 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 4 months ago (2017-07-27 06:38:15 UTC) #2
mithro
LGTM.
3 years, 4 months ago (2017-07-27 06:43:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985203002/1
3 years, 4 months ago (2017-07-27 06:57:58 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 07:05:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/29440f13003b1bf3464be6e4d65904e9ff7ad251

Powered by Google App Engine
This is Rietveld 408576698