[vm] Add error messages for large literals coming from kernel

[vm] Add error messages for large literals coming from kernel

This CL introduces additional error checking for the case when VM runs
in --limit-ints-to-64-bits mode (with integers limited to 64 bits) but
reads .dill files with large integer literals (produced with unlimited
integers).

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed: https://github.com/dart-lang/sdk/commit/230363a3d3a16deab99c4e6764e9db9ac9db31ca

[alexmarkov, 2017-07-27 02:33:36]

Description was changed from

==========
Add error messages for large literals coming from kernel

This CL introduces additional error checking for the case when VM runs
in --limit-ints-to-64-bits mode (with integers limited to 64 bits) but
reads .dill files with large integer literals (produced with unlimited
integers).

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
[vm] Add error messages for large literals coming from kernel

This CL introduces additional error checking for the case when VM runs
in --limit-ints-to-64-bits mode (with integers limited to 64 bits) but
reads .dill files with large integer literals (produced with unlimited
integers).

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

[alexmarkov, 2017-07-27 02:33:58]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, sigmund@google.com, zra@google.com

[zra, 2017-07-27 16:31:44]

lgtm

I like having UNREACHABLE() after functions like ReportError() that look like
they don't return, but I didn't check that that's how ReportError() works, and
it doesn't seem to be the style followed in that file. So up to you.

https://codereview.chromium.org/2985193002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/2985193002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:2271: H.ReportError("Integer literal %s is
out of range", value.ToCString());
If code after ReportError is unreachable, it can be helpful to put an
UNREACHABLE() after.

[alexmarkov, 2017-07-28 17:42:43]

https://codereview.chromium.org/2985193002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/2985193002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:2271: H.ReportError("Integer literal %s is
out of range", value.ToCString());
On 2017/07/27 16:31:44, zra wrote:
> If code after ReportError is unreachable, it can be helpful to put an
> UNREACHABLE() after.

Done.

[alexmarkov, 2017-07-28 17:44:22]

Description was changed from

==========
[vm] Add error messages for large literals coming from kernel

This CL introduces additional error checking for the case when VM runs
in --limit-ints-to-64-bits mode (with integers limited to 64 bits) but
reads .dill files with large integer literals (produced with unlimited
integers).

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
[vm] Add error messages for large literals coming from kernel

This CL introduces additional error checking for the case when VM runs
in --limit-ints-to-64-bits mode (with integers limited to 64 bits) but
reads .dill files with large integer literals (produced with unlimited
integers).

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed:
https://github.com/dart-lang/sdk/commit/230363a3d3a16deab99c4e6764e9db9ac9db31ca
==========

[alexmarkov, 2017-07-28 17:44:23]

Committed patchset #2 (id:20001) manually as
230363a3d3a16deab99c4e6764e9db9ac9db31ca (presubmit successful).