Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2985193002: [vm] Add error messages for large literals coming from kernel (Closed)
Patch Set: Add UNREACHABLE() after ReportError Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index c014d3337f42713cd01bc4a221b96ef104811ef7..261bbe6312b05b8b3e1b4575bd610a7bca80a4a4 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -38,13 +38,19 @@ class SimpleExpressionConverter {
uint8_t payload = 0;
Tag tag = builder_->ReadTag(&payload); // read tag.
switch (tag) {
- case kBigIntLiteral:
- simple_value_ = &Integer::ZoneHandle(
- Z, Integer::New(
- H.DartString(builder_->ReadStringReference(),
- Heap::kOld))); // read index into string table.
+ case kBigIntLiteral: {
+ const dart::String& literal_str =
+ H.DartString(builder_->ReadStringReference(),
+ Heap::kOld); // read index into string table.
+ simple_value_ = &Integer::ZoneHandle(Z, Integer::New(literal_str));
+ if (simple_value_->IsNull()) {
+ H.ReportError("Integer literal %s is out of range",
+ literal_str.ToCString());
+ UNREACHABLE();
+ }
*simple_value_ = H.Canonicalize(*simple_value_);
return true;
+ }
case kStringLiteral:
simple_value_ = &H.DartSymbol(
builder_->ReadStringReference()); // read index into string table.
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698