Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2984913002: Add HTTP error annotation. (Closed)

Created:
3 years, 5 months ago by lexer
Modified:
3 years, 4 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add HTTP error annotation. This allows the status to be retrieved programmatically. R=maruel@google.com BUG= Review-Url: https://codereview.chromium.org/2984913002 Committed: https://github.com/luci/luci-go/commit/a443973d083ad00ce12186a32cb8ac379591d6da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M common/errors/tags.go View 1 chunk +1 line, -1 line 0 comments Download
M common/lhttp/client.go View 2 chunks +16 lines, -1 line 0 comments Download
M common/lhttp/client_test.go View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lexer
3 years, 5 months ago (2017-07-24 17:39:31 UTC) #1
M-A Ruel
lgtm
3 years, 4 months ago (2017-07-27 21:02:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2984913002/1
3 years, 4 months ago (2017-07-27 21:18:49 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 21:52:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/a443973d083ad00ce12186a32cb8ac379591d6da

Powered by Google App Engine
This is Rietveld 408576698