Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: runtime/vm/service.cc

Issue 2984883002: Remove fields from Isolate in Product mode (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index be4bd31e197364af831d05df3b095d19ff40f326..1d925b382ea3dfd0ca528985b94c56c47b00aabb 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -979,6 +979,7 @@ void Service::SendEventWithData(const char* stream_id,
SendEvent(stream_id, event_type, message, total_bytes);
}
+#if !defined(PRODUCT)
static void ReportPauseOnConsole(ServiceEvent* event) {
const char* name = event->isolate()->debugger_name();
switch (event->kind()) {
@@ -1034,14 +1035,17 @@ static void ReportPauseOnConsole(ServiceEvent* event) {
OS::PrintErr("%s\n", err.ToErrorCString());
}
}
+#endif
void Service::HandleEvent(ServiceEvent* event) {
if (event->stream_info() != NULL && !event->stream_info()->enabled()) {
+#if !defined(PRODUCT)
if (FLAG_warn_on_pause_with_no_debugger && event->IsPause()) {
// If we are about to pause a running program which has no
// debugger connected, tell the user about it.
ReportPauseOnConsole(event);
}
+#endif
// Ignore events when no one is listening to the event stream.
return;
}

Powered by Google App Engine
This is Rietveld 408576698