chrome/browser/resources/settings/controls/settings_dropdown_menu.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/pref_control_behavior.js ('k') | chrome/browser/resources/settings/controls/settings_idle_load.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.js

diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

index e3fddcf7fc3b934cf0a68bb3238fd4e9f079bb98..d043b4bbc71ae34b4876dc4d151ae427403adf1f 100644

--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

@@ -97,11 +97,11 @@ Polymer({

// Wait for the dom-repeat to populate the <select> before setting

// <select>#value so the correct option gets selected.

- this.async(function() {

+ this.async(() => {

this.$.dropdownMenu.value = option == undefined ?

this.notFoundValue_ :

Settings.PrefUtil.prefToString(assert(this.pref));

- }.bind(this));

+ });

/**