chrome/browser/resources/settings/controls/pref_control_behavior.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/pref_control_behavior.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js ('k') | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/pref_control_behavior.js

diff --git a/chrome/browser/resources/settings/controls/pref_control_behavior.js b/chrome/browser/resources/settings/controls/pref_control_behavior.js

index dd3e55b4cfe51af92b1407701c5c5aad53fefb1b..d7597657387a22656d233e6c96a8949a01c48836 100644

--- a/chrome/browser/resources/settings/controls/pref_control_behavior.js

+++ b/chrome/browser/resources/settings/controls/pref_control_behavior.js

@@ -29,7 +29,7 @@ var PrefControlBehavior = {

* @private

validatePref_: function() {

- CrSettingsPrefs.initialized.then(function() {

+ CrSettingsPrefs.initialized.then(() => {

if (!this.pref) {

var error = 'Pref not found for element ' + this.tagName;

if (this.id)

@@ -37,6 +37,6 @@ var PrefControlBehavior = {

error += ' in ' + this.domHost.tagName;

console.error(error);

}

- }.bind(this));

+ });

};