chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Fix compiler errors, newly revealed. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js ('K') | « chrome/browser/resources/settings/downloads_page/downloads_page.js ('k') | chrome/browser/resources/settings/internet_page/internet_known_networks_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index 8be3b0c1c8703e9e1876afab23e8f7c776d08826..d4b4d387fb1c1a1d6700a2e094e3ab040b2b4ea0 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -349,13 +349,13 @@ Polymer({

return;

assert(!!this.guid);

- this.networkingPrivate.setProperties(this.guid, onc, function() {

+ this.networkingPrivate.setProperties(this.guid, onc, () => {

if (chrome.runtime.lastError) {

// An error typically indicates invalid input; request the properties

// to update any invalid fields.

this.getNetworkDetails_();

}

- }.bind(this));

+ });

/**