chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Fix compiler errors, newly revealed. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/about_page/about_page_browser_proxy.js ('K') | « chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

index 24bdd3640095c68c4cf70ebf188b05cf23772ea8..588389a0309ea9a1c1d4a3478701e7582d304843 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

@@ -29,8 +29,10 @@ cr.define('settings', function() {

class ClearBrowsingDataBrowserProxy {

/**

* @param {!Array<!ImportantSite>} importantSites

- * @return {!Promise<void>}

- * A promise resolved when data clearing has completed.

+ * @return {!Promise<boolean>}

dpapad 2017/07/22 00:00:44 Necessary to fix compiler error in clear_browsing_

+ * A promise resolved when data clearing has completed. The boolean

+ * indicates whether an additional dialog should be shown, informing the

+ * user about other forms of browsing history.

clearBrowsingData(importantSites) {}