chrome/browser/resources/settings/about_page/about_page_browser_proxy.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Fix compiler errors, newly revealed. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.js ('k') | chrome/browser/resources/settings/about_page/channel_switcher_dialog.js » ('j') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

diff --git a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

index beb4b67e2ecc289f30d4ca22c1254b89345891de..790bfe75a999971c520f1f48f02a53a24cbb2a93 100644

--- a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

+++ b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

@@ -18,8 +18,8 @@ var RegulatoryInfo;

/**

* @typedef {{

- * currentChannel: string,

- * targetChannel: string,

+ * currentChannel: BrowserChannel,

dpapad 2017/07/22 00:00:43 Necessary to fix compiler error in about_page.js.

michaelpg 2017/07/24 05:55:17 Should this appear after the BrowserChannel defini

dpapad 2017/07/24 17:56:50 Given that closure compiler accepts referring to B

+ * targetChannel: BrowserChannel,

* canChangeChannel: boolean,

* }}