Issue 2984783002: Fix and assert getLocalFunction invariant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2984783002: Fix and assert getLocalFunction invariant (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5 lines)			Patch
M	pkg/compiler/lib/src/js_model/closure.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

lgtm. thanks on this. I was dealing with this very thing before my motherboard died.

3 years, 5 months ago (2017-07-21 21:53:37 UTC) #3

Johnni Winther

3 years, 4 months ago (2017-07-28 11:42:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e5f5b95961a62f20810420d05394602686e73b8e (presubmit successful).