Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: pkg/compiler/lib/src/js_model/closure.dart

Issue 2984783002: Fix and assert getLocalFunction invariant (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/kernel/element_map_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_model/closure.dart
diff --git a/pkg/compiler/lib/src/js_model/closure.dart b/pkg/compiler/lib/src/js_model/closure.dart
index 7a021a9ce8355f3c676926460ddf348abcdef12d..7354d13257a8fbb1fe7bb16d037c7af4faaf502a 100644
--- a/pkg/compiler/lib/src/js_model/closure.dart
+++ b/pkg/compiler/lib/src/js_model/closure.dart
@@ -123,7 +123,7 @@ class KernelClosureConversionTask extends ClosureConversionTask<ir.Node> {
/// boxForCapturedVariables stores the local context for those variables.
/// If no variables are captured, this parameter is null.
void _produceSyntheticElements(
- ir.TreeNode /* ir.Field | ir.FunctionNode */ node,
+ ir.TreeNode /* ir.Member | ir.FunctionNode */ node,
ScopeInfo info,
ClosedWorldRefiner closedWorldRefiner) {
Entity entity;
@@ -132,7 +132,8 @@ class KernelClosureConversionTask extends ClosureConversionTask<ir.Node> {
entity = _elementMap.getMember(node);
library = node.enclosingLibrary;
} else {
- entity = _elementMap.getLocalFunction(node);
+ assert(node is ir.FunctionNode);
+ entity = _elementMap.getLocalFunction(node.parent);
// TODO(efortuna): Consider the less roundabout way of getting this value
// which is just storing the "enclosingLibrary" value of the original call
// to CapturedScopeBuilder.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/kernel/element_map_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698