Special-case Timeline.{start,finish}Sync for Fuchsia

Special-case Timeline.{start,finish}Sync for Fuchsia

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/350ad3a4dc5f231b8f871e14052ee721ba676307

[konkers, 2017-07-19 22:11:19]

konkers@google.com changed reviewers:
+ konkers@google.com

[konkers, 2017-07-19 22:11:20]

Tesed and confirmed that the trace events labels are getting set in Fuchsia.

https://codereview.chromium.org/2984603002/diff/20001/runtime/lib/timeline.cc
File runtime/lib/timeline.cc (right):

https://codereview.chromium.org/2984603002/diff/20001/runtime/lib/timeline.cc...
runtime/lib/timeline.cc:158: #if defined(HOST_OS_FUCHSIA)
This is not strictly necessary.  It does, however, reduce the amount of data we
need to store for each trace event.

[zra, 2017-07-20 16:27:57]

zra@google.com changed reviewers:
+ rmacnak@google.com

[zra, 2017-07-20 16:27:57]

PTAL

[siva, 2017-07-20 16:36:30]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-07-20 16:36:31]

https://codereview.chromium.org/2984603002/diff/40001/runtime/lib/timeline.cc
File runtime/lib/timeline.cc (right):

https://codereview.chromium.org/2984603002/diff/40001/runtime/lib/timeline.cc...
runtime/lib/timeline.cc:145: #else
Do you think we need a OS abstraction around this to avoid having Fuchsia
conditional code in this common file. It would depend on whether we are going to
have more of these Fuchsia specific stuff or it is just this one piece.

[zra, 2017-07-20 16:57:04]

https://codereview.chromium.org/2984603002/diff/40001/runtime/lib/timeline.cc
File runtime/lib/timeline.cc (right):

https://codereview.chromium.org/2984603002/diff/40001/runtime/lib/timeline.cc...
runtime/lib/timeline.cc:145: #else
On 2017/07/20 16:36:31, siva wrote:
> Do you think we need a OS abstraction around this to avoid having Fuchsia
> conditional code in this common file. It would depend on whether we are going
to
> have more of these Fuchsia specific stuff or it is just this one piece.

There are probably going to be more pieces because we shouldn't really be doing
"CompleteWithPreSerializedJSON()" on Fuchsia. I think it would make sense to do
the refactoring in this CL, so I will take a look at that now.

[zra, 2017-07-20 22:51:39]

Factored out platform-specific code. PTAL.

[siva, 2017-07-21 00:29:52]

lgtm

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_an...
File runtime/vm/timeline_android.cc (right):

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_an...
runtime/vm/timeline_android.cc:161: #endif  // !PRODUCT

// defined(HOST_OS_ANDROID) && !defined(PRODUCT)

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_fu...
File runtime/vm/timeline_fuchsia.cc (right):

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_fu...
runtime/vm/timeline_fuchsia.cc:207: #endif  // !PRODUCT
ditto here and other files.

[zra, 2017-07-21 15:06:18]

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_an...
File runtime/vm/timeline_android.cc (right):

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_an...
runtime/vm/timeline_android.cc:161: #endif  // !PRODUCT
On 2017/07/21 00:29:52, siva wrote:
> 
> // defined(HOST_OS_ANDROID) && !defined(PRODUCT)

Done.

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_fu...
File runtime/vm/timeline_fuchsia.cc (right):

https://codereview.chromium.org/2984603002/diff/120001/runtime/vm/timeline_fu...
runtime/vm/timeline_fuchsia.cc:207: #endif  // !PRODUCT
On 2017/07/21 00:29:52, siva wrote:
> ditto here and other files.

Done.

[zra, 2017-07-21 15:06:40]

Description was changed from

==========
Special-case Timeline.{start,finish}Sync for Fuchsia
==========

to

==========
Special-case Timeline.{start,finish}Sync for Fuchsia

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/350ad3a4dc5f231b8f871e14052ee721ba676307
==========

[zra, 2017-07-21 15:06:41]

Committed patchset #8 (id:140001) manually as
350ad3a4dc5f231b8f871e14052ee721ba676307 (presubmit successful).