Special-case Timeline.{start,finish}Sync for Fuchsia

runtime/lib/timeline.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 
 #include "vm/native_entry.h"
 #include "vm/object.h"
@@ skipping 55 matching lines @@
   if (recorder == NULL) {
     return Object::null();
   }
 
   TimelineEvent* event = Timeline::GetDartStream()->StartEvent();
   if (event == NULL) {
     // Stream was turned off.
     return Object::null();
   }
 
-  int64_t pid = OS::ProcessId();
-  OSThread* os_thread = thread->os_thread();
-  ASSERT(os_thread != NULL);
-  int64_t tid = OSThread::ThreadIdToIntPtr(os_thread->trace_id());
-  // Convert phase to a C string and perform a sanity check.
-  const char* phase_string = phase.ToCString();
-  ASSERT(phase_string != NULL);
-  ASSERT((phase_string[0] == 'n') || (phase_string[0] == 'b') ||
-         (phase_string[0] == 'e'));
-  ASSERT(phase_string[1] == '\0');
-  char* json = OS::SCreate(
-      zone,
-      "{\"name\":\"%s\",\"cat\":\"%s\",\"tid\":%" Pd64 ",\"pid\":%" Pd64
-      ","
-      "\"ts\":%" Pd64 ",\"ph\":\"%s\",\"id\":%" Pd64 ", \"args\":%s}",
-      name.ToCString(), category.ToCString(), tid, pid, start.AsInt64Value(),
-      phase_string, id.AsInt64Value(), args.ToCString());
-
-  switch (phase_string[0]) {
-    case 'n':
-      event->AsyncInstant("", id.AsInt64Value(), start.AsInt64Value());
-      break;
-    case 'b':
-      event->AsyncBegin("", id.AsInt64Value(), start.AsInt64Value());
-      break;
-    case 'e':
-      event->AsyncEnd("", id.AsInt64Value(), start.AsInt64Value());
-      break;
-    default:
-      UNREACHABLE();
-  }
-
-  // json was allocated in the zone and a copy will be stored in event.
-  event->CompleteWithPreSerializedJSON(json);
+  DartTimelineEventHelpers::ReportTaskEvent(
+      thread, zone, event, start.AsInt64Value(), id.AsInt64Value(),
+      phase.ToCString(), category.ToCString(), name.ToCString(),
+      args.ToCString());
 #endif
   return Object::null();
 }
 
 DEFINE_NATIVE_ENTRY(Timeline_reportCompleteEvent, 5) {
 #ifndef PRODUCT
   if (!FLAG_support_timeline) {
     return Object::null();
   }
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, start, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, start_cpu, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(String, category, arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(3));
   GET_NON_NULL_NATIVE_ARGUMENT(String, args, arguments->NativeArgAt(4));
 
   TimelineEventRecorder* recorder = Timeline::recorder();
   if (recorder == NULL) {
     return Object::null();
   }
 
   TimelineEvent* event = Timeline::GetDartStream()->StartEvent();
   if (event == NULL) {
     // Stream was turned off.
     return Object::null();
   }
 
-  const int64_t end = OS::GetCurrentMonotonicMicros();
-  const int64_t end_cpu = OS::GetCurrentThreadCPUMicros();
-  const int64_t duration = end - start.AsInt64Value();
-  const int64_t duration_cpu = end_cpu - start_cpu.AsInt64Value();
-  int64_t pid = OS::ProcessId();
-  OSThread* os_thread = thread->os_thread();
-  ASSERT(os_thread != NULL);
-  int64_t tid = OSThread::ThreadIdToIntPtr(os_thread->trace_id());
-
-  char* json = NULL;
-
-  if ((start_cpu.AsInt64Value() != -1) && (end_cpu != -1)) {
-    json = OS::SCreate(
-        zone,
-        "{\"name\":\"%s\",\"cat\":\"%s\",\"tid\":%" Pd64 ",\"pid\":%" Pd64
-        ","
-        "\"ts\":%" Pd64 ",\"ph\":\"X\",\"dur\":%" Pd64
-        ","
-        "\"tdur\":%" Pd64 ",\"args\":%s}",
-        name.ToCString(), category.ToCString(), tid, pid, start.AsInt64Value(),
-        duration, duration_cpu, args.ToCString());
-  } else {
-    json = OS::SCreate(
-        zone,
-        "{\"name\":\"%s\",\"cat\":\"%s\",\"tid\":%" Pd64 ",\"pid\":%" Pd64
-        ","
-        "\"ts\":%" Pd64 ",\"ph\":\"X\",\"dur\":%" Pd64 ",\"args\":%s}",
-        name.ToCString(), category.ToCString(), tid, pid, start.AsInt64Value(),
-        duration, args.ToCString());
-  }
-  ASSERT(json != NULL);
-
-  event->Duration("", start.AsInt64Value(), end, start_cpu.AsInt64Value(),
-                  end_cpu);
-  // json was allocated in the zone and a copy will be stored in event.
-  event->CompleteWithPreSerializedJSON(json);
-#endif
+  DartTimelineEventHelpers::ReportCompleteEvent(
+      thread, zone, event, start.AsInt64Value(), start_cpu.AsInt64Value(),
+      category.ToCString(), name.ToCString(), args.ToCString());
+#endif  // !defined(PRODUCT)
   return Object::null();
 }
 
 DEFINE_NATIVE_ENTRY(Timeline_reportInstantEvent, 4) {
 #ifndef PRODUCT
   if (!FLAG_support_timeline) {
     return Object::null();
   }
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, start, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(String, category, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(String, args, arguments->NativeArgAt(3));
 
   TimelineEventRecorder* recorder = Timeline::recorder();
   if (recorder == NULL) {
     return Object::null();
   }
 
   TimelineEvent* event = Timeline::GetDartStream()->StartEvent();
   if (event == NULL) {
     // Stream was turned off.
     return Object::null();
   }
 
-  int64_t pid = OS::ProcessId();
-  OSThread* os_thread = thread->os_thread();
-  ASSERT(os_thread != NULL);
-  int64_t tid = OSThread::ThreadIdToIntPtr(os_thread->trace_id());
-
-  char* json = OS::SCreate(zone,
-                           "{\"name\":\"%s\",\"cat\":\"%s\",\"tid\":%" Pd64
-                           ",\"pid\":%" Pd64
-                           ","
-                           "\"ts\":%" Pd64 ",\"ph\":\"I\",\"args\":%s}",
-                           name.ToCString(), category.ToCString(), tid, pid,
-                           start.AsInt64Value(), args.ToCString());
-
-  event->Instant("", start.AsInt64Value());
-  // json was allocated in the zone and a copy will be stored in event.
-  event->CompleteWithPreSerializedJSON(json);
+  DartTimelineEventHelpers::ReportInstantEvent(
+      thread, zone, event, start.AsInt64Value(), category.ToCString(),
+      name.ToCString(), args.ToCString());
 #endif
   return Object::null();
 }
 
 }  // namespace dart