chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java - Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

index 52212441a57f874409c60f01c1c7e02a0a2193b1..4b35cc3c537efb427d1a05a69c8f75b7b281ac97 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

@@ -29,7 +29,6 @@ public abstract class TabModelSelectorBase implements TabModelSelector {

private boolean mTabStateInitialized;

protected final void initialize(boolean startIncognito, TabModel... models) {

- // Only normal and incognito supported for now.

Yusuf 2017/07/18 22:59:47 is this not the case anymore?

ltian 2017/08/07 23:24:12 Sorry, it must be something I accidentally deleted

assert mTabModels.isEmpty();

assert models.length > 0;

if (startIncognito) {